From: Matthew Auld <matthew.auld@intel.com>
To: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [drm-intel-next PATCH] drm/xe: fix build failure originating from backmerge
Date: Tue, 22 Oct 2024 09:19:46 +0100 [thread overview]
Message-ID: <ef474dc3-d338-4645-a0e6-25ca3de7ffda@intel.com> (raw)
In-Reply-To: <20241022080943.763580-1-jani.nikula@intel.com>
On 22/10/2024 09:09, Jani Nikula wrote:
> ../drivers/gpu/drm/xe/display/xe_display.c: In function ‘xe_display_pm_shutdown’:
> ../drivers/gpu/drm/xe/display/xe_display.c:382:27: error: passing argument 1 of ‘intel_dmc_suspend’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> 382 | intel_dmc_suspend(xe);
> | ^~
> | |
> | struct xe_device *
> In file included from ../drivers/gpu/drm/xe/display/xe_display.c:24:
> ../drivers/gpu/drm/i915/display/intel_dmc.h:22:46: note: expected ‘struct intel_display *’ but argument is of type ‘struct xe_device *’
> 22 | void intel_dmc_suspend(struct intel_display *display);
> | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
>
> Fixes: c141cf76918e ("Merge drm/drm-next into drm-intel-next")
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Matthew Auld <matthew.auld@intel.com>
> ---
> drivers/gpu/drm/xe/display/xe_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index 957ae763531d..ca00a365080f 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -379,7 +379,7 @@ void xe_display_pm_shutdown(struct xe_device *xe)
>
> intel_opregion_suspend(display, PCI_D3cold);
>
> - intel_dmc_suspend(xe);
> + intel_dmc_suspend(display);
> }
>
> void xe_display_pm_runtime_suspend(struct xe_device *xe)
next prev parent reply other threads:[~2024-10-22 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 8:09 [drm-intel-next PATCH] drm/xe: fix build failure originating from backmerge Jani Nikula
2024-10-22 8:19 ` Matthew Auld [this message]
2024-10-22 9:13 ` Jani Nikula
2024-10-22 8:21 ` ✗ CI.Patch_applied: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef474dc3-d338-4645-a0e6-25ca3de7ffda@intel.com \
--to=matthew.auld@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox