Re: [PATCH] drm/xe: Revert "drm/i915: Disable DSB in Xe KMD"

["Souza, Jose" <jose.souza@intel.com>]

On Fri, 2024-03-22 at 17:12 +0530, Animesh Manna wrote:
> This reverts commit c27f010aa1884276ee5dae72034d84987060c769.
> 
> After fix from [1] dsb timeout issue is not reproducible on local testing
> with xe driver. Checking CI result to confirm and not for review.

Have you tested with a full desktop? like starting gnome on X, start gnome on wayland... the running browser on top? Have you tested that on TGL, DG2
and MTL at lest?

This feature was enabled even being completely broken with a full desktop on Xe KMD, so please make sure it is fully tested before enabling it again.

> 
> [1] https://patchwork.freedesktop.org/series/130783/
> 
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dsb.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index 4baaa92ceaec..e06e94ee2f5c 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -468,10 +468,6 @@ struct intel_dsb *intel_dsb_prepare(const struct intel_crtc_state *crtc_state,
>  	if (!HAS_DSB(i915))
>  		return NULL;
>  
> -	/* TODO: DSB is broken in Xe KMD, so disabling it until fixed */
> -	if (!IS_ENABLED(I915))
> -		return NULL;
> -
>  	dsb = kzalloc(sizeof(*dsb), GFP_KERNEL);
>  	if (!dsb)
>  		goto out;