Re: [PATCH 2/8] drm/xe/xe_pci_error: Implement PCI error recovery callbacks

[Riana Tauro <riana.tauro@intel.com>]

On 2/8/2026 1:32 PM, Raag Jadav wrote:
> On Thu, Jan 22, 2026 at 03:36:14PM +0530, Riana Tauro wrote:
>> Add error_detected, mmio_enabled, slot_reset and resume
>> recovery callbacks to handle PCIe Advanced Error Reporting
>> (AER) errors.
>>
>> For fatal errors, the device is wedged and becomes
>> inaccessible. Return PCI_ERS_RESULT_SLOT_RESET from
>> error_detected to request a Secondary Bus Reset (SBR).
>>
>> For non-fatal errors, return PCI_ERS_RESULT_CAN_RECOVER from
>> error_detected to trigger the mmio_enabled callback. In this callback,
>> the device is queried to determine the error cause and attempt
>> recovery based on the error type.
>>
>> Once the secondary bus reset(SBR) is completed the slot_reset callback
>> cleanly removes and reprobe the device to restore functionality.
> 
> ...
> 
>> +static void xe_pci_error_handling(struct pci_dev *pdev)
>> +{
>> +	struct xe_device *xe = pdev_to_xe_device(pdev);
>> +
>> +	xe_device_set_in_recovery(xe);
>> +	xe_device_declare_wedged(xe);
> 
> Is this the correct usage?
> 
> Documentation/gpu/drm-uapi.rst +392
> 
> "A 'wedged' device is basically a device that is declared dead by the driver
> after exhausting all possible attempts to recover it from driver context."

Can't this be used?

"The only exception to this is WEDGED=none, which signifies that the 
device was temporarily ‘wedged’ at some point but was recovered from 
driver context using device specific methods like reset. No explicit 
recovery is expected from the consumer in this case, but it can still 
take additional steps like gathering telemetry information (devcoredump, 
syslog). "

If not will replace it with the gt_wedged function and block ioctls 
using recovery flag

Thanks
Riana



> 
> Raag
> 
>> +	pci_disable_device(pdev);
>> +}