From: Matthew Auld <matthew.auld@intel.com>
To: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
intel-xe@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Matthew Brost <matthew.brost@intel.com>
Subject: Re: [PATCH 1/2] drm/xe: Use xe_pm_runtime_get in xe_bo_move() if reclaim-safe.
Date: Tue, 3 Sep 2024 10:03:53 +0100 [thread overview]
Message-ID: <f04dca6b-a93e-49d8-afb6-b82b0641f0f6@intel.com> (raw)
In-Reply-To: <20240902142042.77581-1-thomas.hellstrom@linux.intel.com>
On 02/09/2024 15:20, Thomas Hellström wrote:
> xe_bo_move() might be called in the TTM swapout path from validation
> by another TTM device. If so, we are not likely to have a RPM
> reference. So iff xe_pm_runtime_get() is safe to call from reclaim,
> use it instead of xe_pm_runtime_get_noresume().
>
> Strictly this is currently needed only if handle_system_ccs is true,
> but use xe_pm_runtime_get() if possible anyway to increase test
> coverage.
>
> At the same time warn if handle_system_ccs is true and we can't
> call xe_pm_runtime_get() from reclaim context. This will likely trip
> if someone tries to enable SRIOV on LNL, without fixing Xe SRIOV
> runtime resume / suspend.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
prev parent reply other threads:[~2024-09-03 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 14:20 [PATCH 1/2] drm/xe: Use xe_pm_runtime_get in xe_bo_move() if reclaim-safe Thomas Hellström
2024-09-02 14:20 ` [PATCH 2/2] drm/xe: Add a xe_bo subtest for shrinking / swapping Thomas Hellström
2024-09-02 14:58 ` ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Use xe_pm_runtime_get in xe_bo_move() if reclaim-safe Patchwork
2024-09-02 14:58 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-02 14:59 ` ✓ CI.KUnit: success " Patchwork
2024-09-02 15:11 ` ✓ CI.Build: " Patchwork
2024-09-02 15:14 ` ✓ CI.Hooks: " Patchwork
2024-09-02 15:15 ` ✓ CI.checksparse: " Patchwork
2024-09-02 16:05 ` ✗ CI.BAT: failure " Patchwork
2024-09-02 17:40 ` ✗ CI.FULL: " Patchwork
2024-09-03 9:03 ` Matthew Auld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f04dca6b-a93e-49d8-afb6-b82b0641f0f6@intel.com \
--to=matthew.auld@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox