Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: harry.wentland@amd.com, jani.nikula@linux.intel.com,
	mwen@igalia.com, contact@emersion.fr, alex.hung@amd.com,
	daniels@collabora.com, uma.shankar@intel.com,
	suraj.kandpal@intel.com, nfraprado@collabora.com,
	ville.syrjala@linux.intel.com, matthew.d.roper@intel.com
Subject: Re: [PATCH v2 11/13] drm/vkms: Remove drm_colorop_pipeline_destroy() from vkms_destroy()
Date: Mon, 12 Jan 2026 15:33:59 +0100	[thread overview]
Message-ID: <f222ced2-7147-42d2-8151-496708f41fb8@bootlin.com> (raw)
In-Reply-To: <20260109081728.478844-12-chaitanya.kumar.borah@intel.com>



On 1/9/26 09:17, Chaitanya Kumar Borah wrote:
> Now that colorops are cleaned from drm_mode_config_cleanup(), remove
> drm_colorop_pipeline_destroy() from  vkms_destroy().
> 
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>

> ---
>   drivers/gpu/drm/vkms/vkms_drv.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 434c295f44ba..95020765c4c2 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -259,7 +259,6 @@ void vkms_destroy(struct vkms_config *config)
>   
>   	fdev = config->dev->faux_dev;
>   
> -	drm_colorop_pipeline_destroy(&config->dev->drm);
>   	drm_dev_unregister(&config->dev->drm);
>   	drm_atomic_helper_shutdown(&config->dev->drm);
>   	devres_release_group(&fdev->dev, NULL);


  reply	other threads:[~2026-01-12 14:33 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09  8:17 [PATCH v2 00/13] drm: Color pipeline teardown and follow-up fixes/improvements Chaitanya Kumar Borah
2026-01-09  8:17 ` [PATCH v2 01/13] drm/i915/color: Place 3D LUT after CSC in plane color pipeline Chaitanya Kumar Borah
2026-01-09  8:17 ` [PATCH v2 02/13] drm/amd/display: Fix color pipeline enum name leak Chaitanya Kumar Borah
2026-01-09  8:17 ` [PATCH v2 03/13] drm/vkms: " Chaitanya Kumar Borah
2026-01-12 14:31   ` Louis Chauvet
2026-01-09  8:17 ` [PATCH v2 04/13] drm/i915/display: " Chaitanya Kumar Borah
2026-01-09  8:17 ` [PATCH v2 05/13] drm/colorop: Add destroy helper for colorop objects Chaitanya Kumar Borah
2026-01-12 11:23   ` Jani Nikula
2026-01-13 10:53     ` Borah, Chaitanya Kumar
2026-01-09  8:17 ` [PATCH v2 06/13] drm: Allow driver-managed destruction of " Chaitanya Kumar Borah
2026-01-09  8:17 ` [PATCH v2 07/13] drm/amd/display: Hook up colorop destroy helper for plane pipelines Chaitanya Kumar Borah
2026-01-09  8:17 ` [PATCH v2 08/13] drm/vkms: " Chaitanya Kumar Borah
2026-01-12 14:33   ` Louis Chauvet
2026-01-09  8:17 ` [PATCH v2 09/13] drm/i915/display: Hook up intel_colorop_destroy Chaitanya Kumar Borah
2026-01-09  8:17 ` [PATCH v2 10/13] drm: Clean up colorop objects during mode_config cleanup Chaitanya Kumar Borah
2026-01-09  8:17 ` [PATCH v2 11/13] drm/vkms: Remove drm_colorop_pipeline_destroy() from vkms_destroy() Chaitanya Kumar Borah
2026-01-12 14:33   ` Louis Chauvet [this message]
2026-01-09  8:17 ` [PATCH v2 12/13] drm/colorop: Use destroy callback for color pipeline teardown Chaitanya Kumar Borah
2026-01-09  8:17 ` [PATCH v2 13/13] drm/i915/color: Add failure handling in plane color pipeline init Chaitanya Kumar Borah
2026-01-09  9:20   ` Kandpal, Suraj
2026-01-09  8:52 ` ✗ CI.checkpatch: warning for drm: Color pipeline teardown and follow-up fixes/improvements (rev2) Patchwork
2026-01-09  8:53 ` ✓ CI.KUnit: success " Patchwork
2026-01-09  9:08 ` ✗ CI.checksparse: warning " Patchwork
2026-01-09  9:27 ` ✓ Xe.CI.BAT: success " Patchwork
2026-01-09 10:24 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f222ced2-7147-42d2-8151-496708f41fb8@bootlin.com \
    --to=louis.chauvet@bootlin.com \
    --cc=alex.hung@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=contact@emersion.fr \
    --cc=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=mwen@igalia.com \
    --cc=nfraprado@collabora.com \
    --cc=suraj.kandpal@intel.com \
    --cc=uma.shankar@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox