Re: [PATCH 1/2] drm/xe/uc: Remove static from loop variable

[John Harrison <john.c.harrison@intel.com>]

On 3/7/2025 10:13 AM, Lucas De Marchi wrote:
> The `entries` variable is used to loop through the array - it's supposed
> to be const, but not static.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

> ---
>   drivers/gpu/drm/xe/xe_uc_fw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index 18e06ee9e23fc..c22da0ce9fb0d 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
> @@ -225,8 +225,8 @@ uc_fw_auto_select(struct xe_device *xe, struct xe_uc_fw *uc_fw)
>   		[XE_UC_FW_TYPE_HUC] = { entries_huc, ARRAY_SIZE(entries_huc) },
>   		[XE_UC_FW_TYPE_GSC] = { entries_gsc, ARRAY_SIZE(entries_gsc) },
>   	};
> -	static const struct uc_fw_entry *entries;
>   	enum xe_platform p = xe->info.platform;
> +	const struct uc_fw_entry *entries;
>   	u32 count;
>   	int i;
>   
>