From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDA9BFED9E8 for ; Tue, 17 Mar 2026 16:26:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B194610E5AB; Tue, 17 Mar 2026 16:26:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="gQWiqiDG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0943C10E5AB; Tue, 17 Mar 2026 16:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773764802; x=1805300802; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=EgXDQ2U1UAUzIypGSiaRe3dom76HCtVViUkEQ9c/JFg=; b=gQWiqiDGtAx3zS7M8PGOryv12+3ro259RRqyPVbWkMAAUeU8c9xUZNMQ jdlAE2L9y1DecvrqYd/ZkqkDexGKo1BY77rcKEYp9ClrxAipvCzK5JJVD YhIpBjbwFXGT7C53Jd0RKs640enhTIwLqFgGJav7eYFK0u1gmEVP513q4 esnz5kRsLwqKkXcGTkBxFxfWONbo4al0tK4T5Ke8Bvn4RVvnrI0QUzFdM AL2qV0IE1MhpG50I6ICbVqdn0xCOg0Dyb7f5lYTGkY8WQaAwa+xPOInNm OPWRybTSHjASvrZhYqjs5EO/LwxjoHQm00Q4qBdoLFEevxZHGs9hXs7t3 g==; X-CSE-ConnectionGUID: 5BH7iItTRJGBnij5mvjggQ== X-CSE-MsgGUID: d2ke/1m0SqmmHlaluDW8Kg== X-IronPort-AV: E=McAfee;i="6800,10657,11732"; a="74718069" X-IronPort-AV: E=Sophos;i="6.23,126,1770624000"; d="scan'208";a="74718069" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 09:26:41 -0700 X-CSE-ConnectionGUID: yMljdHXJTUOA6BxQ3OBu5Q== X-CSE-MsgGUID: VcIAzr1iS6ygQvve7csstw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,126,1770624000"; d="scan'208";a="226456013" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.161]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2026 09:26:37 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Tue, 17 Mar 2026 18:26:34 +0200 (EET) To: "David E. Box" cc: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.com, Hans de Goede , LKML , platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 15/22] platform/x86/intel/pmc/ssram: Rename probe and PCI ID table for consistency In-Reply-To: <20260313015202.3660072-16-david.e.box@linux.intel.com> Message-ID: References: <20260313015202.3660072-1-david.e.box@linux.intel.com> <20260313015202.3660072-16-david.e.box@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323328-565571473-1773764794=:968" X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-565571473-1773764794=:968 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE On Thu, 12 Mar 2026, David E. Box wrote: > Rename intel_pmc_ssram_telemetry_probe() to pmc_ssram_telemetry_probe() a= nd > intel_pmc_ssram_telemetry_pci_ids[] to pmc_ssram_telemetry_pci_ids[], > updating the MODULE_DEVICE_TABLE() and pci_driver wiring accordingly. >=20 > This aligns the symbol names with the driver filename and module name, > reduces redundant intel_ prefixes, and improves readability. No functiona= l > behavior changes are intended. >=20 > Signed-off-by: David E. Box > --- > drivers/platform/x86/intel/pmc/ssram_telemetry.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/platform/x86/intel/pmc/ssram_telemetry.c b/drivers/p= latform/x86/intel/pmc/ssram_telemetry.c > index 6f6e83e70fc5..1deb4d71da3f 100644 > --- a/drivers/platform/x86/intel/pmc/ssram_telemetry.c > +++ b/drivers/platform/x86/intel/pmc/ssram_telemetry.c > @@ -149,7 +149,7 @@ int pmc_ssram_telemetry_get_pmc_info(unsigned int pmc= _idx, > } > EXPORT_SYMBOL_GPL(pmc_ssram_telemetry_get_pmc_info); > =20 > -static int intel_pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const= struct pci_device_id *id) > +static int pmc_ssram_telemetry_probe(struct pci_dev *pcidev, const struc= t pci_device_id *id) > { > =09int ret; > =20 > @@ -183,7 +183,7 @@ static int intel_pmc_ssram_telemetry_probe(struct pci= _dev *pcidev, const struct > =09return ret; > } > =20 > -static const struct pci_device_id intel_pmc_ssram_telemetry_pci_ids[] = =3D { > +static const struct pci_device_id pmc_ssram_telemetry_pci_ids[] =3D { > =09{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_MTL_SOCM) }, > =09{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCS) }, > =09{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCM) }, > @@ -193,14 +193,14 @@ static const struct pci_device_id intel_pmc_ssram_t= elemetry_pci_ids[] =3D { > =09{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_WCL_PCDN) }, > =09{ } > }; > -MODULE_DEVICE_TABLE(pci, intel_pmc_ssram_telemetry_pci_ids); > +MODULE_DEVICE_TABLE(pci, pmc_ssram_telemetry_pci_ids); > =20 > -static struct pci_driver intel_pmc_ssram_telemetry_driver =3D { > +static struct pci_driver pmc_ssram_telemetry_driver =3D { > =09.name =3D "intel_pmc_ssram_telemetry", > -=09.id_table =3D intel_pmc_ssram_telemetry_pci_ids, > -=09.probe =3D intel_pmc_ssram_telemetry_probe, > +=09.id_table =3D pmc_ssram_telemetry_pci_ids, > +=09.probe =3D pmc_ssram_telemetry_probe, > }; > -module_pci_driver(intel_pmc_ssram_telemetry_driver); > +module_pci_driver(pmc_ssram_telemetry_driver); > =20 > MODULE_IMPORT_NS("INTEL_VSEC"); > MODULE_AUTHOR("Xi Pardee "); >=20 Reviewed-by: Ilpo J=E4rvinen --=20 i. --8323328-565571473-1773764794=:968--