✗ CI.checkpatch: warning for platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry

Patchwork
2026-03-13T02:03:00Z

== Series Details ==

Series: platform/x86/intel: Add ACPI PMT discovery support and enable NVL PMC telemetry
URL : https://patchwork.freedesktop.org/series/163153/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
1f57ba1afceae32108bd24770069f764d940a0e4
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit c6ad9fd2741bc94906ee853fc5bfcf93dd14a75b
Author: David E. Box <david.e.box@linux.intel.com>
Date: Thu Mar 12 18:52:01 2026 -0700

platform/x86/intel/pmc: Add NVL PCI IDs for SSRAM telemetry discovery

Add Nova Lake S PMC device IDs to enable binding of the SSRAM telemetry
driver on NVL platforms, and map them to the ACPI-based discovery policy.

Signed-off-by: David E. Box <david.e.box@linux.intel.com>
+ /mt/dim checkpatch 29044d219ec91738869fef9d445adce5e31df374 drm-intel
66e85e74d93e platform/x86/intel/vsec: Refactor base_addr handling
b8ee9c75b28d platform/x86/intel/vsec: Make driver_data info const
8fe8d86c72aa platform/x86/intel/vsec: Decouple add/link helpers from PCI
-:12: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#12:
PCI-specific plumbing where it isn’t strictly required and rely on generic

total: 0 errors, 1 warnings, 0 checks, 64 lines checked
d6e7abba3f2d platform/x86/intel/vsec: Switch exported helpers from pci_dev to device
27a4e3ef33ea platform/x86/intel/vsec: Return real error codes from registration path
ca083ee2b965 platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec
421a6832ed25 platform/x86/intel/pmt: Add pre/post decode hooks around header parsing
bf475653263d platform/x86/intel/pmt/crashlog: Split init into pre-decode
d4bb24f76133 platform/x86/intel/pmt/telemetry: Move overlap check to post-decode hook
3e6ec039cb06 platform/x86/intel/pmt: Move header decode into common helper
a9a00c4f3404 platform/x86/intel/pmt: Pass discovery index instead of resource
4e5e6947e71e platform/x86/intel/pmt: Unify header fetch and add ACPI source
e741fe7b4d3e platform/x86/intel/pmc: Add PMC SSRAM Kconfig description
a62480cf193c platform/x86/intel/pmc: Add ACPI PWRM telemetry driver for Nova Lake S
-:89: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#89:
new file mode 100644

total: 0 errors, 1 warnings, 0 checks, 277 lines checked
42c264b9edc0 platform/x86/intel/pmc/ssram: Rename probe and PCI ID table for consistency
-:35: ERROR:MISSING_SENTINEL: missing sentinel in ID array
#35: FILE: drivers/platform/x86/intel/pmc/ssram_telemetry.c:186:
+static const struct pci_device_id pmc_ssram_telemetry_pci_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_MTL_SOCM) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCS) },
{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PMC_DEVID_ARL_SOCM) },

total: 1 errors, 0 warnings, 0 checks, 35 lines checked
d3fe316e2ff2 platform/x86/intel/pmc/ssram: Use fixed-size static pmc array
-:23: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#23: FILE: drivers/platform/x86/intel/pmc/ssram_telemetry.c:25:
DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
[...]
+static struct pmc_ssram_telemetry pmc_ssram_telems[3];

total: 0 errors, 1 warnings, 0 checks, 28 lines checked
d34f0306fb4b platform/x86/intel/pmc/ssram: Refactor DEVID/PWRMBASE extraction into helper
0fe34022f206 platform/x86/intel/pmc/ssram: Add PCI platform data
-:21: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#21: FILE: drivers/platform/x86/intel/pmc/ssram_telemetry.c:25:
DEFINE_FREE(pmc_ssram_telemetry_iounmap, void __iomem *, if (_T) iounmap(_T))
[...]
+enum resource_method {

total: 0 errors, 1 warnings, 0 checks, 107 lines checked
d199b85a74eb platform/x86/intel/pmc/ssram: Refactor memory barrier for reentrant probe
46cbd20ea62e platform/x86/intel/pmc/ssram: Add ACPI discovery scaffolding
b4539a12438d platform/x86/intel/pmc/ssram: Make PMT registration optional
c6ad9fd2741b platform/x86/intel/pmc: Add NVL PCI IDs for SSRAM telemetry discovery