Re: [PATCH 5/6] drm/xe/ptl: Add PTL platform definition

["Chauhan, Shekhar" <shekhar.chauhan@intel.com>]

On 10/8/2024 7:05, Matt Atwood wrote:
> From: Haridhar Kalvala <haridhar.kalvala@intel.com>
>
> PTL is an integrated GPU based on the Xe3 architecture.
>
> v2: explicitly turn off display until display patches land.
>
> Bspec: 72574
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Haridhar Kalvala <haridhar.kalvala@intel.com>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
LGTM,

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com>

> ---
>   drivers/gpu/drm/xe/xe_pci.c            |  7 +++++++
>   drivers/gpu/drm/xe/xe_platform_types.h |  1 +
>   include/drm/intel/xe_pciids.h          | 11 +++++++++++
>   3 files changed, 19 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 2139edba9062..4085bb3b6550 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -350,6 +350,12 @@ static const struct xe_device_desc bmg_desc = {
>   	.has_heci_cscfi = 1,
>   };
>   
> +static const struct xe_device_desc ptl_desc = {
> +	PLATFORM(PANTHERLAKE),
> +	.has_display = false,
> +	.require_force_probe = true,
> +};
> +
>   #undef PLATFORM
>   __diag_pop();
>   
> @@ -400,6 +406,7 @@ static const struct pci_device_id pciidlist[] = {
>   	XE_MTL_IDS(INTEL_VGA_DEVICE, &mtl_desc),
>   	XE_LNL_IDS(INTEL_VGA_DEVICE, &lnl_desc),
>   	XE_BMG_IDS(INTEL_VGA_DEVICE, &bmg_desc),
> +	XE_PTL_IDS(INTEL_VGA_DEVICE, &ptl_desc),
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(pci, pciidlist);
> diff --git a/drivers/gpu/drm/xe/xe_platform_types.h b/drivers/gpu/drm/xe/xe_platform_types.h
> index 79b7042c4534..d08574c4cdb8 100644
> --- a/drivers/gpu/drm/xe/xe_platform_types.h
> +++ b/drivers/gpu/drm/xe/xe_platform_types.h
> @@ -23,6 +23,7 @@ enum xe_platform {
>   	XE_METEORLAKE,
>   	XE_LUNARLAKE,
>   	XE_BATTLEMAGE,
> +	XE_PANTHERLAKE,
>   };
>   
>   enum xe_subplatform {
> diff --git a/include/drm/intel/xe_pciids.h b/include/drm/intel/xe_pciids.h
> index 65520a90c17c..6d8d013f74e0 100644
> --- a/include/drm/intel/xe_pciids.h
> +++ b/include/drm/intel/xe_pciids.h
> @@ -220,4 +220,15 @@
>   	MACRO__(0xE20D, ## __VA_ARGS__), \
>   	MACRO__(0xE212, ## __VA_ARGS__)
>   
> +#define XE_PTL_IDS(MACRO__, ...) \
> +	MACRO__(0xB080, ## __VA_ARGS__), \
> +	MACRO__(0xB081, ## __VA_ARGS__), \
> +	MACRO__(0xB082, ## __VA_ARGS__), \
> +	MACRO__(0xB090, ## __VA_ARGS__), \
> +	MACRO__(0xB091, ## __VA_ARGS__), \
> +	MACRO__(0xB092, ## __VA_ARGS__), \
> +	MACRO__(0xB0A0, ## __VA_ARGS__), \
> +	MACRO__(0xB0A1, ## __VA_ARGS__), \
> +	MACRO__(0xB0A2, ## __VA_ARGS__)
> +
>   #endif

-- 
-shekhar