Re: [PATCH v15 3/5] drm/xe/guc: Add capture size check in GuC log buffer

["Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>]

alan: everything looks good to me except for one unused function per below.
I'll give you a conditional-rb please ensure remove that on the next rev.

Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>

...alan

On Tue, 2024-08-06 at 07:57 -0700, Zhanjun Dong wrote:
> Capture-nodes generated by GuC are placed in the GuC capture ring
> buffer which is a sub-region of the larger Guc-Log-buffer.
> Add capture output size check before allocating the shared buffer.
> 
> 
alan:snip
> diff --git a/drivers/gpu/drm/xe/xe_guc_log.c b/drivers/gpu/drm/xe/xe_guc_log.c
> index a37ee3419428..250696df92cc 100644
> --- a/drivers/gpu/drm/xe/xe_guc_log.c
> +++ b/drivers/gpu/drm/xe/xe_guc_log.c
> @@ -12,6 +12,11 @@
>  #include "xe_map.h"
>  #include "xe_module.h"
>  
> +static inline struct xe_guc *log_to_guc(struct xe_guc_log *log)
> +{
> +       return container_of(log, struct xe_guc, log);
> +}
alan: (conditional-rb) please remove this function since i dont see it being used anywhere in the entire series.

alan:snip

>  #endif