Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yadav, Arvind" <arvind.yadav@intel.com>
To: Tejas Upadhyay <tejas.upadhyay@intel.com>,
	<intel-xe@lists.freedesktop.org>
Cc: <matthew.auld@intel.com>, <matthew.brost@intel.com>,
	<thomas.hellstrom@linux.intel.com>,
	<himal.prasad.ghimiray@intel.com>
Subject: Re: [RFC PATCH V9 05/10] drm/xe: Extend BO purge to handle vram pages as well
Date: Fri, 15 May 2026 13:22:32 +0530	[thread overview]
Message-ID: <f5fda675-e56e-41dc-bb40-1f366c36a25b@intel.com> (raw)
In-Reply-To: <20260506141143.4033299-17-tejas.upadhyay@intel.com>

LGTM:
Reviewed-by:  Arvind Yadav <arvind.yadav@intel.com>

On 06-05-2026 19:41, Tejas Upadhyay wrote:
> Recent driver update introduce support for purgeable buffer
> objects (BOs), extending the API to include VRAM pages to
> better manage memory pressure and enable memory offlining.
>
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_bo.c | 5 +----
>   drivers/gpu/drm/xe/xe_bo.h | 1 +
>   2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
> index 5ce60d161e09..04d3b25c7c8e 100644
> --- a/drivers/gpu/drm/xe/xe_bo.c
> +++ b/drivers/gpu/drm/xe/xe_bo.c
> @@ -903,7 +903,7 @@ void xe_bo_set_purgeable_state(struct xe_bo *bo,
>    *
>    * Return: 0 on success, negative error code on failure
>    */
> -static int xe_ttm_bo_purge(struct ttm_buffer_object *ttm_bo, struct ttm_operation_ctx *ctx)
> +int xe_ttm_bo_purge(struct ttm_buffer_object *ttm_bo, struct ttm_operation_ctx *ctx)
>   {
>   	struct xe_bo *bo = ttm_to_xe_bo(ttm_bo);
>   	struct ttm_placement place = {};
> @@ -911,9 +911,6 @@ static int xe_ttm_bo_purge(struct ttm_buffer_object *ttm_bo, struct ttm_operatio
>   
>   	xe_bo_assert_held(bo);
>   
> -	if (!ttm_bo->ttm)
> -		return 0;
> -
>   	if (!xe_bo_madv_is_dontneed(bo))
>   		return 0;
>   
> diff --git a/drivers/gpu/drm/xe/xe_bo.h b/drivers/gpu/drm/xe/xe_bo.h
> index 68dea7d25a6b..9f55b3589caf 100644
> --- a/drivers/gpu/drm/xe/xe_bo.h
> +++ b/drivers/gpu/drm/xe/xe_bo.h
> @@ -500,6 +500,7 @@ struct xe_bo_shrink_flags {
>   long xe_bo_shrink(struct ttm_operation_ctx *ctx, struct ttm_buffer_object *bo,
>   		  const struct xe_bo_shrink_flags flags,
>   		  unsigned long *scanned);
> +int xe_ttm_bo_purge(struct ttm_buffer_object *ttm_bo, struct ttm_operation_ctx *ctx);
>   
>   /**
>    * xe_bo_is_mem_type - Whether the bo currently resides in the given

  reply	other threads:[~2026-05-15  7:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 14:11 [RFC PATCH V9 00/10] Add memory page offlining support Tejas Upadhyay
2026-05-06 14:11 ` [RFC PATCH V9 01/10] drm/xe: Link VRAM object with gpu buddy Tejas Upadhyay
2026-05-06 14:11 ` [RFC PATCH V9 02/10] [DO_NOT_REVIEW]gpu/buddy: Integrate lockdep for gpu buddy manager Tejas Upadhyay
2026-05-06 14:11 ` [RFC PATCH V9 03/10] drm/gpu: Add gpu_buddy_allocated_addr_to_block helper Tejas Upadhyay
2026-05-06 14:11 ` [RFC PATCH V9 04/10] drm/xe: Link LRC BO and its execution Queue Tejas Upadhyay
2026-05-06 14:11 ` [RFC PATCH V9 05/10] drm/xe: Extend BO purge to handle vram pages as well Tejas Upadhyay
2026-05-15  7:52   ` Yadav, Arvind [this message]
2026-05-06 14:11 ` [RFC PATCH V9 06/10] drm/xe: Handle physical memory address error Tejas Upadhyay
2026-05-06 14:11 ` [RFC PATCH V9 07/10] drm/xe/cri: Add debugfs to inject faulty vram address Tejas Upadhyay
2026-05-06 14:11 ` [RFC PATCH V9 08/10] gpu/buddy: Add routine to dump allocated buddy blocks Tejas Upadhyay
2026-05-06 14:11 ` [RFC PATCH V9 09/10] drm/xe/configfs: Add vram bad page reservation policy Tejas Upadhyay
2026-05-06 14:11 ` [RFC PATCH V9 10/10] drm/xe/cri: Add sysfs interface for bad gpu vram pages Tejas Upadhyay
2026-05-06 14:18 ` ✗ CI.checkpatch: warning for Add memory page offlining support (rev9) Patchwork
2026-05-06 14:19 ` ✗ CI.KUnit: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5fda675-e56e-41dc-bb40-1f366c36a25b@intel.com \
    --to=arvind.yadav@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=tejas.upadhyay@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox