From: "Nilawar, Badal" <badal.nilawar@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>,
<igt-dev@lists.freedesktop.org>, <janga.rahul.kumar@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
Anshuman Gupta <anshuman.gupta@intel.com>,
Francois Dugast <francois.dugast@intel.com>
Subject: Re: [PATCH i-g-t 3/5] tests/intel/xe_pm: Also disable display for mmap_system test
Date: Tue, 14 May 2024 12:16:39 +0530 [thread overview]
Message-ID: <f6dd61dc-a1f1-4df8-a13e-ebb807196881@intel.com> (raw)
In-Reply-To: <20240513185518.772398-3-rodrigo.vivi@intel.com>
On 14-05-2024 00:25, Rodrigo Vivi wrote:
> If display is enabled, the always-on components will always
> keeps runtime pm references, unless you put DPMS_OFF.
>
> Cc: Badal Nilawar <badal.nilawar@intel.com>
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Cc: Francois Dugast <francois.dugast@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> tests/intel/xe_pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c
> index 3f963bd9b..72d484163 100644
> --- a/tests/intel/xe_pm.c
> +++ b/tests/intel/xe_pm.c
> @@ -780,7 +780,9 @@ igt_main
> igt_describe("Validate mmap memory mappings with system region,"
> "when device along with parent bridge in d3");
> igt_subtest("d3-mmap-system") {
> + dpms_on_off(device, DRM_MODE_DPMS_OFF);
> test_mmap(device, system_memory(device.fd_xe), 0);
> + dpms_on_off(device, DRM_MODE_DPMS_ON);
Rahul, please consider this change for mocs tests you added recently in
xe_pm.c.
Meanwhile this is
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
Regards,
Badal Nilawar
> }
>
> igt_describe("Validate mmap memory mappings with vram region,"
next prev parent reply other threads:[~2024-05-14 6:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 18:55 [PATCH i-g-t 1/5] tests/intel/xe_pm: Update runtime pm conditions Rodrigo Vivi
2024-05-13 18:55 ` [PATCH i-g-t 2/5] lib/igt_pm: Fix and standardize IGT PM library documentation Rodrigo Vivi
2024-05-14 6:49 ` Riana Tauro
2024-05-13 18:55 ` [PATCH i-g-t 3/5] tests/intel/xe_pm: Also disable display for mmap_system test Rodrigo Vivi
2024-05-14 6:12 ` Gupta, Anshuman
2024-05-14 6:46 ` Nilawar, Badal [this message]
2024-05-13 18:55 ` [PATCH i-g-t 4/5] tests/intel/xe_pm: Only check the rpm resume after the first mmap operation Rodrigo Vivi
2024-05-14 15:19 ` Nilawar, Badal
2024-05-14 16:39 ` Nilawar, Badal
2024-05-13 18:55 ` [PATCH i-g-t 5/5] tests/intel/xe_pm: Convert mmap tests to use existing d3 helpers Rodrigo Vivi
2024-05-13 19:01 ` ✗ CI.Patch_applied: failure for series starting with [i-g-t,1/5] tests/intel/xe_pm: Update runtime pm conditions Patchwork
2024-05-13 20:03 ` Rodrigo Vivi
2024-05-16 16:49 ` [PATCH i-g-t 1/5] " Francois Dugast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6dd61dc-a1f1-4df8-a13e-ebb807196881@intel.com \
--to=badal.nilawar@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=francois.dugast@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=janga.rahul.kumar@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox