From: "Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>,
intel-xe@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Jonathan Cavitt" <jonathan.cavitt@intel.com>,
"Matthew Brost" <matthew.brost@intel.com>
Subject: Re: [PATCH] drm/xe: Don't treat SR-IOV platforms as reclaim unsafe
Date: Thu, 6 Feb 2025 13:05:14 +0100 [thread overview]
Message-ID: <f6fecda7-4783-4b1d-9e20-cee034be24fb@linux.intel.com> (raw)
In-Reply-To: <20250205120150.896-1-michal.wajdeczko@intel.com>
On 2/5/2025 1:01 PM, Michal Wajdeczko wrote:
> Since commit a4d1c5d0b99b ("drm/xe/pf: Move VFs reprovisioning
> to worker") and commit 78d5d1e20d1d ("drm/xe/relay: Don't use
> GFP_KERNEL for new transactions") we should have no more lockdep
> dependencies on the reclaim path when running in the SRIOV mode
> so we believe that we can now mark SRIOV driver as reclaim safe.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/xe/xe_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 35dd1757b40b..12200be7b43d 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -91,7 +91,7 @@ static struct lockdep_map xe_pm_runtime_nod3cold_map = {
> */
> bool xe_rpm_reclaim_safe(const struct xe_device *xe)
> {
> - return !xe->d3cold.capable && !xe->info.has_sriov;
> + return !xe->d3cold.capable;
> }
LGTM
Tested-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
>
> static void xe_rpm_lockmap_acquire(const struct xe_device *xe)
next prev parent reply other threads:[~2025-02-06 12:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 12:01 [PATCH] drm/xe: Don't treat SR-IOV platforms as reclaim unsafe Michal Wajdeczko
2025-02-05 13:33 ` ✓ CI.Patch_applied: success for " Patchwork
2025-02-05 13:34 ` ✓ CI.checkpatch: " Patchwork
2025-02-05 13:35 ` ✓ CI.KUnit: " Patchwork
2025-02-05 14:03 ` ✓ CI.Build: " Patchwork
2025-02-05 14:06 ` ✓ CI.Hooks: " Patchwork
2025-02-05 14:07 ` ✓ CI.checksparse: " Patchwork
2025-02-05 14:27 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-05 17:04 ` ✗ Xe.CI.Full: failure " Patchwork
2025-02-05 17:21 ` Michal Wajdeczko
2025-02-06 12:05 ` Bernatowicz, Marcin [this message]
2025-02-06 15:06 ` [PATCH] " Thomas Hellström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6fecda7-4783-4b1d-9e20-cee034be24fb@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jonathan.cavitt@intel.com \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox