Re: [PATCH v5 23/23] drm/xe/sriov: Disable SR-IOV if primary GT is disabled via configfs

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 10/13/2025 10:10 PM, Matt Roper wrote:
> SR-IOV operation relies on the primary GT's GuC to operate (in both PF
> and VF mode).  If the primary GT is disabled in VF mode, fail the probe.
> If the primary GT is disabled in PF mode, force the device back to
> native (non-sriov) mode.

I guess we should update this msg to the latest approach:

"Don't enable .has_sriov flag if the primary-GT was disabled by configfs."

and then we can keep the change log under ---

> 
> v2:
>  - Move handling to xe_info_init().  (Michal)
> 
> v3:
>  - Just update the .has_sriov flag in xe_info_init_early().  (Michal)
> 
> v4:
>  - Drop unnecessary comment.  (Michal)
>  - Flip condition order for consistency with other checks.  (Michal)
> 
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_pci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index ef559a79c5ba..24a38904bb50 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -631,7 +631,8 @@ static int xe_info_init_early(struct xe_device *xe,
>  	xe->info.has_late_bind = desc->has_late_bind;
>  	xe->info.has_llc = desc->has_llc;
>  	xe->info.has_pxp = desc->has_pxp;
> -	xe->info.has_sriov = desc->has_sriov;
> +	xe->info.has_sriov = xe_configfs_primary_gt_allowed(to_pci_dev(xe->drm.dev)) &&
> +		desc->has_sriov;

but this part should work, so

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

>  	xe->info.skip_guc_pc = desc->skip_guc_pc;
>  	xe->info.skip_mtcfg = desc->skip_mtcfg;
>  	xe->info.skip_pcode = desc->skip_pcode;