Re: [PATCH 10/19] drm/i915/display: Remove unused dc3co_exitline from intel_crtc_state

Dibin Moolakadan Subrahmanian
2026-04-20T12:26:36Z

On 14-04-2026 03:14, Shankar, Uma wrote:
>
>> -----Original Message-----
>> From: Dibin Moolakadan Subrahmanian
>> <dibin.moolakadan.subrahmanian@intel.com>
>> Sent: Thursday, March 26, 2026 10:46 PM
>> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
>> Cc: Manna, Animesh <animesh.manna@intel.com>; Shankar, Uma
>> <uma.shankar@intel.com>; Kurmi, Suresh Kumar
>> <suresh.kumar.kurmi@intel.com>
>> Subject: [PATCH 10/19] drm/i915/display: Remove unused dc3co_exitline from
>> intel_crtc_state
>>
>> Remove dc3co_exitline from struct intel_crtc_state, as it is not used anywhere in
>> the driver.
>>
>> Also remove the corresponding register read in intel_psr_get_config().
> Change Looks Good, but squash it with earlier patch (9) in the series.

I will squash this and patch 09 into patch 01,
as they all remove existing DC3CO structures.

>
>> Signed-off-by: Dibin Moolakadan Subrahmanian
>> <dibin.moolakadan.subrahmanian@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_display_types.h | 1 -
>> drivers/gpu/drm/i915/display/intel_psr.c | 1 -
>> 2 files changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h
>> b/drivers/gpu/drm/i915/display/intel_display_types.h
>> index 60366087038f..0a327c4df98d 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
>> @@ -1192,7 +1192,6 @@ struct intel_crtc_state {
>> bool pkg_c_latency_used;
>> /* Only used for state verification. */
>> enum intel_panel_replay_dsc_support panel_replay_dsc_support;
>> - u32 dc3co_exitline;
>> u16 su_y_granularity;
>> u8 active_non_psr_pipes;
>> const char *no_psr_reason;
>> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
>> b/drivers/gpu/drm/i915/display/intel_psr.c
>> index 40adbd1c8ddc..987d49536548 100644
>> --- a/drivers/gpu/drm/i915/display/intel_psr.c
>> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
>> @@ -1822,7 +1822,6 @@ void intel_psr_get_config(struct intel_encoder
>> *encoder,
>> if (DISPLAY_VER(display) >= 12) {
>> val = intel_de_read(display,
>> TRANS_EXITLINE(display, cpu_transcoder));
>> - pipe_config->dc3co_exitline =
>> REG_FIELD_GET(EXITLINE_MASK, val);
>> }
>> unlock:
>> mutex_unlock(&intel_dp->psr.lock);
>> --
>> 2.43.0