From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 533FFC67861 for ; Mon, 8 Apr 2024 18:57:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BDCCA10E3A4; Mon, 8 Apr 2024 18:57:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="K+5habAc"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6539810E295 for ; Mon, 8 Apr 2024 18:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712602657; x=1744138657; h=message-id:date:subject:to:references:from:in-reply-to: mime-version; bh=nAI0b1xcFclsUsU9GGh8JSxMXxXHodtcB0pxsmZsgtc=; b=K+5habAcv8c3Wz811lSnKpM4HFfksXchyCCGT2TMpdFV549dco0LQn97 FrOT2wZuAtMaCPV0ZxHvVdyyrx1ke7jNKjeC3EQAjR8tRERvZSC6mc5hn yrfz7qkzN94eeWQTlWQVcgPB5iXzhNHSEQFCwxLBUfKohbCm4XdsikXKO zTxafEp/6kmEknfR0pYCDEz/j0LWSrpLoQ9ZUma2lVZoJrR1uWTn5E+iL B7/I3zu1q9xQxSHeTAgEP6WjllaWzrn+cJIth3GVUXPW2VA/DK2QLJhrE jEzhR1xiUvOq8I52Z0l3AGKixnWpl1nUADC4lcQEucv6uVZJaqh+kKSrr w==; X-CSE-ConnectionGUID: OZTZtLnGSgmu3rfDBxvpJg== X-CSE-MsgGUID: 4+8hZNnRSWWNoJJYMFHF2A== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="8125604" X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208,217";a="8125604" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 11:57:36 -0700 X-CSE-ConnectionGUID: /iDt+nCQQM+sRP2/vl8Pdg== X-CSE-MsgGUID: dBtCM172S2ioxt2bdbuXuw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208,217";a="20102131" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Apr 2024 11:57:36 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Apr 2024 11:57:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Apr 2024 11:57:35 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Apr 2024 11:57:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WcG2XKq1UQ1Aajj1j1JYDq/l72MfBK2P1ZFckSC6Y6N5e0npf97BhH9di7BIe1LMu7hHaPUNHWPPV4PHXZS6a8zueDkqkr99iyTxRiIxaxsVcnUBOU9ENDtc05fZIrApgJRr1X94tlz3ExXffzoaU0k3350Lgqbq/H/8MN82oI9nCvKCk6rOaWX7MIWrT+icHJ6Njao0vfFP2k+0EDNtpapMMVb8aO/EtVLQsGfCJxjyplHbr4bFmFlEc5/En8H6BnBH0oTR9hIm/f3gWAD6Le3MW/sObH8iJ7FRlmR9BduQA9hmISfHFQQK+CILr6YJxBub6HKWg1fRi/1BvjfdIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+JC9XJIWOBW3Kcz0xDJt+yQWR2A+ebxiLsEDTEL9q1M=; b=Pg8lBtm+4SPyRzKOn4iIqkFjI+Mpq7h514bVVO4BOrR3lkVHjyUFdbQPtOHdFMKeNbIJX7ijwEgnbwuEw2iXirZb/O4wpXO47ULNTIX3uFM3T4Q2qJ2TI+ERRdN9nUFxx12qzlT4LCX5yOo7qGRUpeHMcYDY/VJdWNNUAQzVR3ZSJRjYWh9QTDf4fKQk2LspH3cfairzg1MQdBnJNCf5n5rxJcedf1OgnG648AmDUK8ne/6YJuKfinBxT6xaebDdL6KiX1KKC/6pAk32le/cB7SE2MSYtW9MhT5v4t3207sp4aSlldSCagaOMYzHaIiE8qf4uPY8cAe3Qf5uvuF5ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB7056.namprd11.prod.outlook.com (2603:10b6:303:21a::12) by PH0PR11MB5173.namprd11.prod.outlook.com (2603:10b6:510:39::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.20; Mon, 8 Apr 2024 18:57:33 +0000 Received: from MW4PR11MB7056.namprd11.prod.outlook.com ([fe80::8664:8749:8357:f11a]) by MW4PR11MB7056.namprd11.prod.outlook.com ([fe80::8664:8749:8357:f11a%7]) with mapi id 15.20.7452.019; Mon, 8 Apr 2024 18:57:33 +0000 Content-Type: multipart/alternative; boundary="------------9bBp950le4XbfNe5LW0VWhDe" Message-ID: Date: Tue, 9 Apr 2024 00:27:27 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 07/11] drm/xe/xe2hpg: Remove extra allocation of CCS pages for dgfx To: References: <20240408170545.3769566-1-balasubramani.vivekanandan@intel.com> <20240408170545.3769566-8-balasubramani.vivekanandan@intel.com> Content-Language: en-US From: "Ghimiray, Himal Prasad" In-Reply-To: <20240408170545.3769566-8-balasubramani.vivekanandan@intel.com> X-ClientProxiedBy: PN3PR01CA0057.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:99::8) To MW4PR11MB7056.namprd11.prod.outlook.com (2603:10b6:303:21a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW4PR11MB7056:EE_|PH0PR11MB5173:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7vW3aPevIe5v2xiqT+mL5N5ETYAPIHRUJE4cWGGHR9HZNot1N67ZmWHBorb/RsJOopaUWisx8SJZsNc9xV9dRiMrYiPwgbwOVZX4tvD6hUa+kwvwRDzAx6+dDKhrhPXVo1UNTWOe0RIWA8kxhvPHRqPkoqlpTCdK0SjwDypFMwo4/EI5nct3BXV6qZIA9XazkUply8itFUjgXlMMi0AfDN9N3/YISLiI0468Y5vuPoLRgWOT3EAY2C3F1/FkVxvma0MfsWNFUHKqSExxbuSNjUQgc5ckudsQDh8tfyx6p+6exZN96z5hZugot+fcRBEkx0GB7P2sEI4zwUunfeu+FN/HUXfSu8+6/Nb3IZ15St7jCvbH5ys/C4arHPU0e1mT6gcA0iDWmoGdg7TmiWIvAOfhZk1VvC5NVab1bTmZPY6xT2L+z/ZnibuqJJFaoWKoGJdH51RIgvtogffSo8Y3ju4vjqnKOybGZRx5vyarhYYUIcICVsqaaVEfO8RLQLBXm6jur1flEriQzKkPBCk/+WGgBQOybWXbpEkylWmKjMdThjJNINApS1U2Bh3YiFNV5nkSLiKf8PfX5BpNd1+6kFxwxD4bIa+2mggyBhSq7Up4yGmhxKW+rrjD+vgr5LR/E7HVhn5f9oALjvtbGIHyY7d7nY1J3axVB/aqG0R/1i8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MW4PR11MB7056.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3pwd2NDOW5tcWg1VG9vTGtXSlZuY3paNHFlU2FXMXJVelRsS0wrVFV6b0ZQ?= =?utf-8?B?TVFCdFFuWm9tSDV4bUF2ODhIbXZvSzdsSVZEdnJzcGJ6bnhTZlJUcW1nOCt4?= =?utf-8?B?RXlDMnowazVoSDJJdVJzdStaT1dieU5jd0NZRlNjZU83WFVKSS9sRDNEM08v?= =?utf-8?B?ZzZEYkJUZGRReHhEWnBoMWhIcnA5ZUx6T1g3ZjZYeWdWTXZUcG80Z0hGTytY?= =?utf-8?B?SHQ2TXhvUlNnVTlseFZnTFZIUUJJdjBDeVRYSlM0WEdMdElVdzVBbk5hL0Vj?= =?utf-8?B?cGs1bVYxOWFUcU5ZNGtwMGI4MStqMDAvd0FGODFLUzJaVVMvc1dta0Q3dDBI?= =?utf-8?B?ZnEwejJlbWdwalE5MW1nc2pRNGN2T21VdkVBMDJQRTJTZ0g2Z05jc1FPS2dC?= =?utf-8?B?SEhRak5iTHdwQ21HTmpzM1NjdC9mQUVvYlZRSXo2Q2pWZXBRaTUxWDFTUld5?= =?utf-8?B?bzVpSmt2dXJhVUdwdDNWeWRiQ2xIckE1YmlQOGRmWUwvYVpIOHhmT2wydmZ4?= =?utf-8?B?cGlZMkJBV2tqUzFDM3NRa0djbVl4UjErVXZVSFRrZGExZ2Z0WU8wRG85Rkdy?= =?utf-8?B?THpFL0tZRTV1REN4cDlvRzZBSm4vejVKTTFLMUNwL01KbHVXb2NBVjh6a2RL?= =?utf-8?B?ajRSMGNnVVVNZmV2NHZCYytjTXVaL0l3QmtsaXJaeGd1aWxxS29oQ202MFIz?= =?utf-8?B?dWRBWWlMUkcvVFU1b1hHUnZUak80Vy9iTk1tbVJQdmZLL0FQcGQxWXhtOE90?= =?utf-8?B?VFpuaDBLbk5DNEpuV1BSYTBhd0MySGhlMjdsNDl5d1pxc0VGMFlTMUQwdi8w?= =?utf-8?B?LzJqRVdTc0g4YlFyeHdUYmpjOEw0K285bFB6OGpWeTVVQXlyNXVmMkhLd09U?= =?utf-8?B?WVlUTTJlSGU0L0Y4ZHl6QU9rTlVCeXJVellpZzZHUU16V05UeWNKdHVQcHBi?= =?utf-8?B?aHZFNU9Dd1QxZ3JQZUhlYUVrTEdwbFFvZlhLczFrWGJuYytRSEFuUGN1Sjkr?= =?utf-8?B?S05BT0ZmWmYvTGVlVWk3SDZkMFlCQ3R5UkRBOVpRaGxKTU5FdkdWeFIxSk5k?= =?utf-8?B?RFR5aDhMWWJUZll4ZVd2UUJuTTNlcG9zTkoxSmt4eGR6elNFcEx3aSt0R0lV?= =?utf-8?B?WnVCT0s3ZFlWNWFQWk5kRkhaZnBUeHFTTTV0aUR0dFBMZ0dhMTdJR2k4bVdD?= =?utf-8?B?VmlSSTY5eGNiNVZ4a1l5UkRFdm44bEZOSFRWWmpFbVFKSEpTdlFDQzNGZHhD?= =?utf-8?B?NUN3WG10c3dMUHRQZmRDWHRoc0lsSW9UY0ozZUlFOVpMTkwzVG15VlZMejdv?= =?utf-8?B?U3J2dW5NL1lrYnB2bHd3R1ZOV3UwMldmWXFCaWpLa1JvWDJ0YUhRaHJOVklj?= =?utf-8?B?THY3WUtSTFRTMTM4dmZEZ3F3cGlURTdtSitWUmdiSzZJWi9wZWhSaHBvT1FI?= =?utf-8?B?R3hmNUF4RnhCblZiRDNMLzZ6WkNma2pHNmpaVU9TbldpdmVlckVqYUNyelFz?= =?utf-8?B?bnFmVTRzYS9ZLzJyMDZEMEthbWxjcFNaTkhZS3dpRC82eWxsenRYKzJmbllU?= =?utf-8?B?UURsWjM2OUV0K1VBQXdKNGdzWVlzbVBnemNnNFgzRXFPRFNRRmFwMVB1d3pH?= =?utf-8?B?cjVMTVlocE85NXg1M3FCdHZ6QVlUeWdHZDdqY3JMWFovVyt2bzhmMnh0Q0cz?= =?utf-8?B?OFFESzNTMHNEcS9waDhsVVcwbDJLaHAzNkV4ZUxoZ2R4eDhITVFVNmh1ay9r?= =?utf-8?B?WTRmRXgyNFZMRkZLa2JNS2xvQ2ZKOExDSGkycVJQWHgzR3FBaHFFam5kdDRZ?= =?utf-8?B?ZGllTnp3WmVvVVFVRHZRT1ZPZXc3ZS9paHRCNzI1eVlVN0JyN3dvSHo1YVRv?= =?utf-8?B?aTBnTGExeTMxSWMyMWpOSzd4R0FsNUJWcGt4bnlBSlhQVHBiWGF4Y2NZYktE?= =?utf-8?B?QVUxdjM0UEhaNmdNUCtrTUJpRDRMa2J1WHJ4ekhWMnNtWTRsQlVRTklTOXBa?= =?utf-8?B?Y0ErdUVPOTJQVmxzMmo0L3AreVJFRnIybjFMd0lzTnByZFFaTHVNK0UreFZ2?= =?utf-8?B?MjNWenhlUThncVBKRFZVT25BN3IxdnVKS0JBUXpoaFdtQno5dVNSMUlESDFx?= =?utf-8?B?ZkpjektTM0xqOTdXRjlPWXFDY1RiSFZWbEF4SjZZSDNaYm84b2xTYzhaTmxH?= =?utf-8?B?Z3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1c360dc4-4d0d-4c20-eb0f-08dc57fdbf53 X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7056.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2024 18:57:33.1132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ba7g7uOguDFt1Kp8fUpu5/ERMvBScsBYeJ6IjEZbtxXDEC/ZuXvg66/MpuVewA5Q/twZkUGAS/7DptNS85g4Hjw/tvXz+6teZBSgQpZW1fI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5173 X-OriginatorOrg: intel.com X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" --------------9bBp950le4XbfNe5LW0VWhDe Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 08-04-2024 22:35, Balasubramani Vivekanandan wrote: > From: Akshata Jahagirdar > > On Xe2 dGPU, compression is only supported with VRAM. When copying from > VRAM -> system memory the KMD uses mapping with uncompressed PAT > so the copy in system memory is guaranteed to be uncompressed. > When restoring such buffers from system memory -> VRAM the KMD can't > easily know which pages were originally compressed, so we always use > uncompressed -> uncompressed here. > so this means that there's no need for extra CCS storage on such > platforms. > > v2: More description added to commit message > > Signed-off-by: Akshata Jahagirdar > Signed-off-by: Balasubramani Vivekanandan > --- > drivers/gpu/drm/xe/xe_bo.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c > index 6166bc715656..fdeb3691d3f6 100644 > --- a/drivers/gpu/drm/xe/xe_bo.c > +++ b/drivers/gpu/drm/xe/xe_bo.c > @@ -2201,6 +2201,9 @@ bool xe_bo_needs_ccs_pages(struct xe_bo *bo) > { > struct xe_device *xe = xe_bo_device(bo); > > + if (GRAPHICS_VER(xe) >= 20 && IS_DGFX(xe)) > + return false; > + LGTM. Reviewed-by: Himal Prasad Ghimiray > if (!xe_device_has_flat_ccs(xe) || bo->ttm.type != ttm_bo_type_device) > return false; > --------------9bBp950le4XbfNe5LW0VWhDe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 7bit


On 08-04-2024 22:35, Balasubramani Vivekanandan wrote:
From: Akshata Jahagirdar <akshata.jahagirdar@intel.com>

On Xe2 dGPU, compression is only supported with VRAM. When copying from
VRAM -> system memory the KMD uses mapping with uncompressed PAT
so the copy in system memory is guaranteed to be uncompressed.
When restoring such buffers from system memory -> VRAM the KMD can't
easily know which pages were originally compressed, so we always use
uncompressed -> uncompressed here.
so this means that there's no need for extra CCS storage on such
platforms.

v2: More description added to commit message

Signed-off-by: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
---
 drivers/gpu/drm/xe/xe_bo.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 6166bc715656..fdeb3691d3f6 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -2201,6 +2201,9 @@ bool xe_bo_needs_ccs_pages(struct xe_bo *bo)
 {
 	struct xe_device *xe = xe_bo_device(bo);
 
+	if (GRAPHICS_VER(xe) >= 20 && IS_DGFX(xe))
+		return false;
+

LGTM.

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

 	if (!xe_device_has_flat_ccs(xe) || bo->ttm.type != ttm_bo_type_device)
 		return false;
--------------9bBp950le4XbfNe5LW0VWhDe--