From: Julia Filipchuk <julia.filipchuk@intel.com>
To: <John.C.Harrison@Intel.com>, <Intel-Xe@Lists.FreeDesktop.Org>
Subject: Re: [PATCH v8 06/11] drm/xe/guc: Use a two stage dump for GuC logs and add more info
Date: Wed, 2 Oct 2024 13:53:54 -0700 [thread overview]
Message-ID: <fa0c4e95-fe1b-4473-8a06-7b20b7809b1b@intel.com> (raw)
In-Reply-To: <20240920032108.629796-7-John.C.Harrison@Intel.com>
On 9/19/2024 8:21 PM, John.C.Harrison@Intel.com wrote:
> +#define GUC_PMTIMESTAMP XE_REG(0xc3e8)
This register seems to be the lower-32 bits of a pair. Does it make
sense to read the full 64-bit counter for the log?
> + err = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
> + if (err) {
> + snapshot->stamp = ~0;
> + } else {
> + snapshot->stamp = xe_mmio_read32(>->mmio, GUC_PMTIMESTAMP);
> + xe_force_wake_put(gt_to_fw(gt), XE_FW_GT);
> + }
next prev parent reply other threads:[~2024-10-02 20:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 3:20 [PATCH v8 00/11] drm/xe/guc: Improve GuC log dumping and add to devcoredump John.C.Harrison
2024-09-20 3:20 ` [PATCH v8 01/11] drm/xe/guc: Remove spurious line feed in debug print John.C.Harrison
2024-09-20 3:20 ` [PATCH v8 02/11] drm/xe/devcoredump: Use drm_puts and already cached local variables John.C.Harrison
2024-10-01 0:59 ` Julia Filipchuk
2024-09-20 3:21 ` [PATCH v8 03/11] drm/xe/devcoredump: Improve section headings and add tile info John.C.Harrison
2024-10-01 1:26 ` Julia Filipchuk
2024-09-20 3:21 ` [PATCH v8 04/11] drm/xe/devcoredump: Add ASCII85 dump helper function John.C.Harrison
2024-10-01 15:56 ` Julia Filipchuk
2024-09-20 3:21 ` [PATCH v8 05/11] drm/xe/guc: Copy GuC log prior to dumping John.C.Harrison
2024-09-20 3:21 ` [PATCH v8 06/11] drm/xe/guc: Use a two stage dump for GuC logs and add more info John.C.Harrison
2024-10-01 22:17 ` Julia Filipchuk
2024-10-02 20:53 ` Julia Filipchuk [this message]
2024-10-02 21:26 ` John Harrison
2024-09-20 3:21 ` [PATCH v8 07/11] drm/print: Introduce drm_line_printer John.C.Harrison
2024-09-20 3:21 ` [PATCH v8 08/11] drm/xe/guc: Dead CT helper John.C.Harrison
2024-09-30 23:04 ` John.C.Harrison
2024-10-02 17:40 ` Julia Filipchuk
2024-10-02 17:28 ` Julia Filipchuk
2024-09-20 3:21 ` [PATCH v8 09/11] drm/xe/guc: Dump entire CTB on errors John.C.Harrison
2024-09-20 3:21 ` [PATCH v8 10/11] drm/xe/guc: Add GuC log to devcoredump captures John.C.Harrison
2024-09-20 3:21 ` [PATCH v8 11/11] drm/xe/guc: Add a helper function for dumping GuC log to dmesg John.C.Harrison
2024-09-20 3:45 ` ✓ CI.Patch_applied: success for drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev3) Patchwork
2024-09-20 3:45 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-20 3:46 ` ✓ CI.KUnit: success " Patchwork
2024-09-20 3:59 ` ✓ CI.Build: " Patchwork
2024-09-20 4:01 ` ✓ CI.Hooks: " Patchwork
2024-09-20 4:17 ` ✗ CI.checksparse: warning " Patchwork
2024-09-20 4:52 ` ✗ CI.BAT: failure " Patchwork
2024-09-20 9:53 ` ✗ CI.FULL: " Patchwork
2024-10-01 0:49 ` ✓ CI.Patch_applied: success for drm/xe/guc: Improve GuC log dumping and add to devcoredump (rev4) Patchwork
2024-10-01 0:49 ` ✗ CI.checkpatch: warning " Patchwork
2024-10-01 0:50 ` ✓ CI.KUnit: success " Patchwork
2024-10-01 1:02 ` ✓ CI.Build: " Patchwork
2024-10-01 1:04 ` ✓ CI.Hooks: " Patchwork
2024-10-01 1:05 ` ✗ CI.checksparse: warning " Patchwork
2024-10-01 1:31 ` ✓ CI.BAT: success " Patchwork
2024-10-01 11:18 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa0c4e95-fe1b-4473-8a06-7b20b7809b1b@intel.com \
--to=julia.filipchuk@intel.com \
--cc=Intel-Xe@Lists.FreeDesktop.Org \
--cc=John.C.Harrison@Intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox