From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAC19C27C40 for ; Thu, 24 Aug 2023 14:51:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9ECC410E56A; Thu, 24 Aug 2023 14:51:42 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 995FA10E563 for ; Thu, 24 Aug 2023 14:51:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692888699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7o8FmS9ILXRLPo1u5nNYGJpJogRKnIzbXnVpr9mrPjw=; b=ccP7kKFHL2F9pJGFGA9JePyB2wNbIVRgMhpE/e6bMFEDJKV4IPj58CXUmvJoNOICaJ3EJT 9rIEKmky6u1uluWoyjHn/py3xv7hFVCe9At6kZmpgBq/Gv8zFQs4IC+vcMUyhyv7a00oC4 E1IEFrmwm+XjyxRrxv2ojkto15Euplo= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-WoIvwVUuM46qrOqC7nvGrQ-1; Thu, 24 Aug 2023 10:51:38 -0400 X-MC-Unique: WoIvwVUuM46qrOqC7nvGrQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-978a991c3f5so520267966b.0 for ; Thu, 24 Aug 2023 07:51:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692888695; x=1693493495; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7o8FmS9ILXRLPo1u5nNYGJpJogRKnIzbXnVpr9mrPjw=; b=Xt0CCVk2UCSVN2zs6PwH2VEWsx1PPJmnodjJbTa+FlvpkVHdf3rRttzld52b4sBS+v mvuW7Z7NLGQJXpwjvZTIrJXWUjQ6W+ZEFAdwFwXJHmR9hqwmIN/Jqzc4lAksvbirtjg3 AbG4DGJqvom42uWPKVWeUviRYIP8oeVIXaQxAEsJVXojT5UzZ5q8Atqr2AHrMNwnECy7 CEaxjJMXJ4WesA6jO4xS815L8hzAWEF4/SPBGF92COkzYP+7C7JjEwFHftyKqWI4ZwD2 Q36aSbs4fLxK/ZvthDxK6WbYxpGMlHSLEfG/SdTQPDbjExPgLhD7wvnbsDvUH7Yqwmnq mhcw== X-Gm-Message-State: AOJu0YxQITZSp1oN3gxnT0FhdFZfkt/IchWqHQTYtMgdVcRu6x64cu0S JdCFQQpL9wcu98PuzFpg7iGZ7sU2Hopcc2Bw6fxB15+B71T8XLytjuzd66kkBvicG2cOzdKe1Z9 Ts4PmMUC/Ixd3VcOLvN0HiV8vfUE= X-Received: by 2002:a17:906:7691:b0:9a1:c39a:8bfd with SMTP id o17-20020a170906769100b009a1c39a8bfdmr5597936ejm.57.1692888695258; Thu, 24 Aug 2023 07:51:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGeDO8RRGYrxEyYcoyUdQLdXSYJyvNZ3g0aSSub2U0DLfFntA3wWoTPcvbRBh/ph2VdVlfrcA== X-Received: by 2002:a17:906:7691:b0:9a1:c39a:8bfd with SMTP id o17-20020a170906769100b009a1c39a8bfdmr5597914ejm.57.1692888694906; Thu, 24 Aug 2023 07:51:34 -0700 (PDT) Received: from ?IPV6:2a02:810d:4b3f:de9c:642:1aff:fe31:a15c? ([2a02:810d:4b3f:de9c:642:1aff:fe31:a15c]) by smtp.gmail.com with ESMTPSA id mb12-20020a170906eb0c00b0099bd5b72d93sm11113573ejb.43.2023.08.24.07.51.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Aug 2023 07:51:34 -0700 (PDT) Message-ID: Date: Thu, 24 Aug 2023 16:51:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Matthew Brost References: <20230811023137.659037-1-matthew.brost@intel.com> <748c267c-1ede-876a-1cac-c864fb37e3dc@redhat.com> From: Danilo Krummrich Organization: RedHat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-xe] [PATCH v2 0/9] DRM scheduler changes for Xe X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, sarah.walker@imgtec.com, ketil.johnsen@arm.com, lina@asahilina.net, Liviu.Dudau@arm.com, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, luben.tuikov@amd.com, donald.robson@imgtec.com, boris.brezillon@collabora.com, christian.koenig@amd.com, faith.ekstrand@collabora.com Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On 8/24/23 05:23, Matthew Brost wrote: > On Thu, Aug 24, 2023 at 02:08:59AM +0200, Danilo Krummrich wrote: >> Hi Matt, >> >> On 8/11/23 04:31, Matthew Brost wrote: >>> As a prerequisite to merging the new Intel Xe DRM driver [1] [2], we >>> have been asked to merge our common DRM scheduler patches first. >>> >>> This a continuation of a RFC [3] with all comments addressed, ready for >>> a full review, and hopefully in state which can merged in the near >>> future. More details of this series can found in the cover letter of the >>> RFC [3]. >>> >>> These changes have been tested with the Xe driver. >> >> Do you keep a branch with these patches somewhere? >> > > Pushed a branch for you: > https://gitlab.freedesktop.org/mbrost/nouveau-drm-scheduler/-/tree/xe-sched-changes?ref_type=heads Great - gonna pick this up to work on making use of DRM_SCHED_POLICY_SINGLE_ENTITY in Nouveau. - Danilo > > Matt > >> - Danilo >> >>> >>> v2: >>> - Break run job, free job, and process message in own work items >>> - This might break other drivers as run job and free job now can run in >>> parallel, can fix up if needed >>> >>> Matt >>> >>> Matthew Brost (9): >>> drm/sched: Convert drm scheduler to use a work queue rather than >>> kthread >>> drm/sched: Move schedule policy to scheduler / entity >>> drm/sched: Add DRM_SCHED_POLICY_SINGLE_ENTITY scheduling policy >>> drm/sched: Split free_job into own work item >>> drm/sched: Add generic scheduler message interface >>> drm/sched: Add drm_sched_start_timeout_unlocked helper >>> drm/sched: Start run wq before TDR in drm_sched_start >>> drm/sched: Submit job before starting TDR >>> drm/sched: Add helper to set TDR timeout >>> >>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +- >>> drivers/gpu/drm/etnaviv/etnaviv_sched.c | 5 +- >>> drivers/gpu/drm/lima/lima_sched.c | 5 +- >>> drivers/gpu/drm/msm/msm_ringbuffer.c | 5 +- >>> drivers/gpu/drm/nouveau/nouveau_sched.c | 5 +- >>> drivers/gpu/drm/panfrost/panfrost_job.c | 5 +- >>> drivers/gpu/drm/scheduler/sched_entity.c | 85 ++++- >>> drivers/gpu/drm/scheduler/sched_fence.c | 2 +- >>> drivers/gpu/drm/scheduler/sched_main.c | 408 ++++++++++++++++----- >>> drivers/gpu/drm/v3d/v3d_sched.c | 25 +- >>> include/drm/gpu_scheduler.h | 75 +++- >>> 11 files changed, 487 insertions(+), 136 deletions(-) >>> >> >