Re: [PATCH v5 6/6] drm/xe: Remove last fence dependency check from binds

["Thomas Hellström" <thomas.hellstrom@linux.intel.com>]

On Wed, 2025-10-29 at 13:57 -0700, Matthew Brost wrote:
> Eliminate redundant last fence dependency checks in bind jobs, as
> they
> are now equivalent to xe_exec_queue_is_idle. Simplify the code by
> removing this dead logic.
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

> ---
>  drivers/gpu/drm/xe/xe_exec_queue.c | 23 -----------------------
>  drivers/gpu/drm/xe/xe_exec_queue.h |  2 --
>  drivers/gpu/drm/xe/xe_pt.c         |  7 -------
>  3 files changed, 32 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c
> b/drivers/gpu/drm/xe/xe_exec_queue.c
> index b7551592fe3f..3486744a8dfd 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.c
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.c
> @@ -1122,29 +1122,6 @@ void xe_exec_queue_last_fence_set(struct
> xe_exec_queue *q, struct xe_vm *vm,
>  	q->last_fence = dma_fence_get(fence);
>  }
>  
> -/**
> - * xe_exec_queue_last_fence_test_dep - Test last fence dependency of
> queue
> - * @q: The exec queue
> - * @vm: The VM the engine does a bind or exec for
> - *
> - * Returns:
> - * -ETIME if there exists an unsignalled last fence dependency, zero
> otherwise.
> - */
> -int xe_exec_queue_last_fence_test_dep(struct xe_exec_queue *q,
> struct xe_vm *vm)
> -{
> -	struct dma_fence *fence;
> -	int err = 0;
> -
> -	fence = xe_exec_queue_last_fence_get(q, vm);
> -	if (fence) {
> -		err = test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence-
> >flags) ?
> -			0 : -ETIME;
> -		dma_fence_put(fence);
> -	}
> -
> -	return err;
> -}
> -
>  /**
>   * xe_exec_queue_tlb_inval_last_fence_put() - Drop ref to last TLB
> invalidation fence
>   * @q: The exec queue
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.h
> b/drivers/gpu/drm/xe/xe_exec_queue.h
> index 1ba7354b33d1..fda4d4f9bda8 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.h
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.h
> @@ -88,8 +88,6 @@ struct dma_fence
> *xe_exec_queue_last_fence_get_for_resume(struct xe_exec_queue *
>  							  struct
> xe_vm *vm);
>  void xe_exec_queue_last_fence_set(struct xe_exec_queue *e, struct
> xe_vm *vm,
>  				  struct dma_fence *fence);
> -int xe_exec_queue_last_fence_test_dep(struct xe_exec_queue *q,
> -				      struct xe_vm *vm);
>  
>  void xe_exec_queue_tlb_inval_last_fence_put(struct xe_exec_queue *q,
>  					    struct xe_vm *vm,
> diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
> index a4b9cdf016d9..01056b51ac9f 100644
> --- a/drivers/gpu/drm/xe/xe_pt.c
> +++ b/drivers/gpu/drm/xe/xe_pt.c
> @@ -1338,13 +1338,6 @@ static int xe_pt_vm_dependencies(struct
> xe_sched_job *job,
>  			return err;
>  	}
>  
> -	if (!(pt_update_ops->q->flags & EXEC_QUEUE_FLAG_KERNEL)) {
> -		if (job)
> -			err = xe_sched_job_last_fence_add_dep(job,
> vm);
> -		else
> -			err =
> xe_exec_queue_last_fence_test_dep(pt_update_ops->q, vm);
> -	}
> -
>  	for (i = 0; job && !err && i < vops->num_syncs; i++)
>  		err = xe_sync_entry_add_deps(&vops->syncs[i], job);
>