Re: [PATCH v2 1/3] drm/xe/uapi: CLOS uapi support

["Welty, Brian" <brian.welty@intel.com>]

On 1/9/2024 3:57 PM, Pallavi Mishra wrote:
> Introduce Class of Service (CLOS) uapi. This allows
> Apps to reserve portions of the GPU Caches for
> exclusive use
I think make this the last patch in the series...
so advertise uapi last after the code is in place in KMD.


> 
> Signed-off-by: Pallavi Mishra <pallavi.mishra@intel.com>
> ---
>   include/uapi/drm/xe_drm.h | 71 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 71 insertions(+)
> 
> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> index 50bbea0992d9..7d5656a55ddf 100644
> --- a/include/uapi/drm/xe_drm.h
> +++ b/include/uapi/drm/xe_drm.h
> @@ -100,6 +100,10 @@ extern "C" {
>   #define DRM_XE_EXEC_QUEUE_GET_PROPERTY	0x08
>   #define DRM_XE_EXEC			0x09
>   #define DRM_XE_WAIT_USER_FENCE		0x0a
> +#define DRM_XE_CLOS_RESERVE		0x0b
> +#define DRM_XE_CLOS_FREE		0x0c
> +#define DRM_XE_CLOS_SET_WAYS		0x0d
> +
>   /* Must be kept compact -- no holes */
>   
>   #define DRM_IOCTL_XE_DEVICE_QUERY		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_DEVICE_QUERY, struct drm_xe_device_query)
> @@ -113,6 +117,9 @@ extern "C" {
>   #define DRM_IOCTL_XE_EXEC_QUEUE_GET_PROPERTY	DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_EXEC_QUEUE_GET_PROPERTY, struct drm_xe_exec_queue_get_property)
>   #define DRM_IOCTL_XE_EXEC			DRM_IOW(DRM_COMMAND_BASE + DRM_XE_EXEC, struct drm_xe_exec)
>   #define DRM_IOCTL_XE_WAIT_USER_FENCE		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_WAIT_USER_FENCE, struct drm_xe_wait_user_fence)
> +#define DRM_IOCTL_XE_CLOS_RESERVE		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_CLOS_RESERVE, struct drm_xe_clos_reserve)
> +#define DRM_IOCTL_XE_CLOS_FREE			DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_CLOS_FREE, struct drm_xe_clos_free)
> +#define DRM_IOCTL_XE_CLOS_SET_WAYS		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_CLOS_SET_WAYS, struct drm_xe_clos_set_ways)
>   
>   /**
>    * DOC: Xe IOCTL Extensions
> @@ -1339,6 +1346,70 @@ struct drm_xe_wait_user_fence {
>   	__u64 reserved[2];
>   };
>   
> +/**
> + * struct drm_xe_clos_reserve
> + *
> + * Allows clients to request reservation of one free CLOS, to use in subsequent
> + * Cache Reservations.
> + *
> + */
> +struct drm_xe_clos_reserve {
> +	/** @clos_index: clos index for reservation */
> +	__u16 clos_index;
> +
> +	/** @pad: MBZ */
> +	__u16 pad16;
> +};
> +
> +/**
> + * struct drm_xe_clos_free
> + *
> + * Free off a previously reserved CLOS set. Any corresponding Cache Reservations
> + * that are active for the CLOS are automatically dropped and returned to the
> + * Shared set.
> + *
> + * The clos_index indicates the CLOS set which is being released and must
> + * correspond to a CLOS index previously reserved.
> + *
> + */
> +struct drm_xe_clos_free {
> +	/** clos_index: free clos index */
> +	__u16 clos_index;
> +
> +	/** @pad: MBZ */
> +	__u16 pad16;
> +};
> +
> +/**
> + * struct drm_xe_clos_set_ways
> + *
> + * Allows clients to request, or release, reservation of one or more cache ways,
> + * within a previously reserved CLOS set.
> + *
> + * If num_ways = 0, KMD will drop any existing Reservation for the specified
> + * clos_index and cache_level. The requested clos_index and cache_level Waymasks
> + * will then track the Shared set once again.
> + *
> + * Otherwise, the requested number of Ways will be removed from the Shared set
> + * for the requested cache level, and assigned to the Cache and CLOS specified
> + * by cache_level/clos_index.
> + *
> + */
> +struct drm_xe_clos_set_ways {
> +	/** @clos_index: reserved clos index */
> +	__u16 clos_index;
> +
> +	/** @cache_level: level of cache  */
> +	__u16 cache_level; /* e.g. 3 for L3 */
> +
> +	/** @num_ways: cache ways */
> +	__u16 num_ways;
> +
> +	/** @pad: MBZ */
> +	__u16 pad16;
> +};
> +
> +
>   #if defined(__cplusplus)
>   }
>   #endif