From: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v3 1/7] drm/xe: Simplify function return using drmm_add_action_or_reset()
Date: Fri, 12 Apr 2024 20:24:14 +0530 [thread overview]
Message-ID: <fd5c6cce-bc4d-4f35-90c2-0875e02f4f0f@intel.com> (raw)
In-Reply-To: <mhkrjisvy5xjgcupsgck2ps3efpjfsq3jgf3buawdj3ji2ogqi@he4rysy6eg7a>
On 12-04-2024 18:22, Lucas De Marchi wrote:
> On Fri, Apr 12, 2024 at 01:32:39PM +0530, Himal Prasad Ghimiray wrote:
>> Instead of assigning the value of drmm_add_action_or_reset() to err and
>> returning err in case of failure and 0 in case of success, simply return
>> the result of drmm_add_action_or_reset().
>>
>> -v2:
>> cleanup in xe_display too.
>>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Thanks for the review.
>
> Lucas De Marchi
next prev parent reply other threads:[~2024-04-12 14:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 8:02 [PATCH 0/4] Cleanup and fixes in drmm_add_action_or_reset usage Himal Prasad Ghimiray
2024-04-12 8:02 ` [PATCH v3 1/7] drm/xe: Simplify function return using drmm_add_action_or_reset() Himal Prasad Ghimiray
2024-04-12 12:52 ` Lucas De Marchi
2024-04-12 14:54 ` Ghimiray, Himal Prasad [this message]
2024-04-12 8:02 ` [PATCH v3 2/7] drm/xe: Incase of action add failure, remove sysfs only once Himal Prasad Ghimiray
2024-04-12 13:09 ` Lucas De Marchi
2024-04-12 13:13 ` Lucas De Marchi
2024-04-12 14:41 ` Jani Nikula
2024-04-12 14:55 ` Ghimiray, Himal Prasad
2024-04-12 8:02 ` [PATCH v3 3/7] drm/xe: Incase of action add failure, free_gsc_pkt " Himal Prasad Ghimiray
2024-04-12 13:14 ` Lucas De Marchi
2024-04-12 15:38 ` Ghimiray, Himal Prasad
2024-04-12 8:02 ` [PATCH v3 4/7] drm/xe: Return NULL incase of drmm_add_action_or_reset failure Himal Prasad Ghimiray
2024-04-12 8:02 ` [PATCH v3 5/7] drm/xe/gt: Abort driver load for sysfs creation failure Himal Prasad Ghimiray
2024-04-12 13:30 ` Lucas De Marchi
2024-04-12 15:38 ` Ghimiray, Himal Prasad
2024-04-12 8:02 ` [PATCH v3 6/7] drm/xe/tile: " Himal Prasad Ghimiray
2024-04-12 13:32 ` Lucas De Marchi
2024-04-12 15:39 ` Ghimiray, Himal Prasad
2024-04-12 8:02 ` [PATCH v3 7/7] drm/xe/pm: Capture errors and handle them Himal Prasad Ghimiray
2024-04-12 13:42 ` Lucas De Marchi
2024-04-12 16:31 ` Ghimiray, Himal Prasad
2024-04-12 16:58 ` Lucas De Marchi
2024-04-12 17:07 ` Ghimiray, Himal Prasad
2024-04-12 8:15 ` ✓ CI.Patch_applied: success for Cleanup and fixes in drmm_add_action_or_reset usage (rev3) Patchwork
2024-04-12 8:15 ` ✓ CI.checkpatch: " Patchwork
2024-04-12 8:17 ` ✓ CI.KUnit: " Patchwork
2024-04-12 8:31 ` ✓ CI.Build: " Patchwork
2024-04-12 8:34 ` ✓ CI.Hooks: " Patchwork
2024-04-12 8:35 ` ✓ CI.checksparse: " Patchwork
2024-04-12 8:58 ` ✓ CI.BAT: " Patchwork
2024-04-12 12:13 ` ✗ CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd5c6cce-bc4d-4f35-90c2-0875e02f4f0f@intel.com \
--to=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox