Re: [PATCH v11 07/20] gpu: nova-core: mm: Add TLB flush support

Danilo Krummrich
2026-04-16T21:45:50Z

On Thu Apr 16, 2026 at 11:23 PM CEST, Joel Fernandes wrote:
> Btw, I changed this to doing it in 2 phases to avoid holding the RCU readlock
> across read_poll_timeout, which can sleep. Will squash it in for v12.

Why do we need the try_access() dance in the first place? I assume this ends up
being called from the BarAccess destructor?

If so, I think this is solvable. Gary and me are currently working on
higher-ranked types and a chained Devres type.

With that, such use-cases should be cleanly solvable without the need for
try_access().

Besides that, I can't find where BarAccess is ever constructed.

It already has a lifetime 'a for &'a Bar1, so I don't see why you can't do the
same for Bar0.

But again, I don't see this being constructed and I'm not sure the whole
construct works in the first place.