Re: drm/xe/hwmon: Enable energy attributes for CRI

["Purkait, Soham" <soham.purkait@intel.com>]

Hi Karthik,

On 10-03-2026 17:50, Karthik Poosa wrote:
> Enable HWMON energy attributes for CRI which is available through
> MMIO registers.
>
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
>   drivers/gpu/drm/xe/regs/xe_pcode_regs.h | 3 +++
>   drivers/gpu/drm/xe/xe_hwmon.c           | 7 ++++++-
>   2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/regs/xe_pcode_regs.h b/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
> index 4b3c46eb858f..c63b409d7a82 100644
> --- a/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_pcode_regs.h
> @@ -27,4 +27,7 @@
>   #define   TEMP_SIGN_MASK			REG_BIT(31)
>   #define BMG_PACKAGE_TEMPERATURE			XE_REG(0x138434)
>   
> +#define CRI_PACKAGE_ENERGY_STATUS		XE_REG(0x138120)
> +#define CRI_PLATFORM_ENERGY_STATUS		XE_REG(0x138458)
> +
>   #endif /* _XE_PCODE_REGS_H_ */
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 0fd4d4f1014a..852681bdb84c 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -296,7 +296,12 @@ static struct xe_reg xe_hwmon_get_reg(struct xe_hwmon *hwmon, enum xe_hwmon_reg
>   			return GT_PERF_STATUS;
>   		break;
>   	case REG_PKG_ENERGY_STATUS:
> -		if (xe->info.platform == XE_PVC && channel == CHANNEL_PKG) {
> +		if (xe->info.platform == XE_CRESCENTISLAND) {
> +			if (channel == CHANNEL_CARD)

Instead of using if-else better to use switch-case here.

Thanks,
Soham

> +				return CRI_PLATFORM_ENERGY_STATUS;
> +			else if (channel == CHANNEL_PKG)
> +				return CRI_PACKAGE_ENERGY_STATUS;
> +		} else if (xe->info.platform == XE_PVC && channel == CHANNEL_PKG) {
>   			return PVC_GT0_PLATFORM_ENERGY_STATUS;
>   		} else if ((xe->info.platform == XE_DG2) && (channel == CHANNEL_PKG)) {
>   			return PCU_CR_PACKAGE_ENERGY_STATUS;