Re: [PATCH] drm/i915/bios: Remove unnecessary checks of PSR idle frames in VBT binary

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 01 Sep 2025, Jouni Högander <jouni.hogander@intel.com> wrote:
> PSR idle frames in VBT binary is a 4 bits wide bitfield. Checking if it's
> below 0 or over 15 doesn't make sense. Remove these checks.
>
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 7d7193a05d88..3596dce84c28 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1567,10 +1567,7 @@ parse_psr(struct intel_display *display,
>  
>  	panel->vbt.psr.full_link = psr_table->full_link;
>  	panel->vbt.psr.require_aux_wakeup = psr_table->require_aux_to_wakeup;
> -
> -	/* Allowed VBT values goes from 0 to 15 */
> -	panel->vbt.psr.idle_frames = psr_table->idle_frames < 0 ? 0 :
> -		psr_table->idle_frames > 15 ? 15 : psr_table->idle_frames;
> +	panel->vbt.psr.idle_frames = psr_table->idle_frames;
>  
>  	/*
>  	 * New psr options 0=500us, 1=100us, 2=2500us, 3=0us

-- 
Jani Nikula, Intel