Re: [PATCH v6 06/12] drm/xe/reg_sr: Report save-restore errors using structured xe_log API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] drm/xe: incomplete refactoring missing xe_gt_err() replacement in xe_reg_sr_add
--

commit 81903de8af1b2d3214fd6a5c1628dc2db69e9354
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

drm/xe/reg_sr: Report save-restore errors using structured xe_log API

This commit replaces xe_gt_notice() and xe_gt_err() calls with xe_log_info()
and xe_log_err() for register save-restore operations.

> diff --git a/drivers/gpu/drm/xe/xe_reg_sr.c b/drivers/gpu/drm/xe/xe_reg_sr.c
> index e328f50725572..eab84a528d122 100644
> --- a/drivers/gpu/drm/xe/xe_reg_sr.c
> +++ b/drivers/gpu/drm/xe/xe_reg_sr.c

[ ... ]

> @@ -219,7 +220,7 @@ void xe_reg_sr_apply_mmio(struct xe_reg_sr *sr, struct xe_gt *gt)
>  
>  	CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FORCEWAKE_ALL);
>  	if (!xe_force_wake_ref_has_domain(fw_ref.domains, XE_FORCEWAKE_ALL)) {
> -		xe_gt_err(gt, "Failed to apply, err=-ETIMEDOUT\n");
> +		xe_log_err(gt, REGS, -ETIMEDOUT, "Failed to apply\n");
>  		return;
>  	}
>  

[Severity: Medium]
Does this commit miss replacing the xe_gt_err() call in xe_reg_sr_add()?

If xe_reg_sr_add() fails (e.g., due to an incompatible entry or memory
allocation failure), it still calls the legacy macro instead of the new
xe_log_err() API:

drivers/gpu/drm/xe/xe_reg_sr.c:xe_reg_sr_add() {
    ...
fail:
	xe_gt_err(gt,
		  "discarding save-restore reg %04lx (clear: %08x, set: %08x, masked: %s, mcr: %s): ret=%d\n",
		  idx, e->clr_bits, e->set_bits,
		  str_yes_no(e->reg.masked),
		  str_yes_no(e->reg.mcr),
		  ret);
	reg_sr_inc_error(sr);

	return ret;
}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012051823.2201360-1-dnyaneshwar.bhadane@intel.com?part=6