Re: [PATCH v7 05/12] drm/xe/memirq: Report errors using structured xe_log API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] deadcode: unused memirq_err macro left in file
--

commit c32c066b460938805d748f9376a0c96a69f7328b
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

    drm/xe/memirq: Report errors using structured xe_log API

This commit replaces memirq_err calls with xe_log_err to report errors using
the structured xe_log API. It updates the error logging in memirq_alloc_pages
and xe_memirq_init_guc to use the new format.

> diff --git a/drivers/gpu/drm/xe/xe_memirq.c b/drivers/gpu/drm/xe/xe_memirq.c
> index 9dfe965cb46ec..32b9f87a10ecf 100644
> --- a/drivers/gpu/drm/xe/xe_memirq.c
> +++ b/drivers/gpu/drm/xe/xe_memirq.c

[ ... ]

> @@ -232,7 +233,7 @@ static int memirq_alloc_pages(struct xe_memirq *memirq)
>  	return 0;
>  
>  out:
> -	memirq_err(memirq, "Failed to allocate memirq page (%pe)\n", ERR_PTR(err));
> +	xe_log_err(tile, MEMIRQ, err, "Failed to allocate memirq page\n");

[Severity: Low]
Since this patch completely replaces all invocations of memirq_err with
xe_log_err, could we also remove the memirq_err macro definition from
drivers/gpu/drm/xe/xe_memirq.c to avoid leaving unused code?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261012122522.2307625-1-dnyaneshwar.bhadane@intel.com?part=5