Re: [PATCH v6 4/4] drm/xe/ggtt: Add KUnit tests for usable and shareable pools

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/xe: unguarded ggtt_test_insert_node_shareable() breaks !CONFIG_PCI_IOV
--

commit 860da7a3db2d0c0c83dbaf117f1d5b696f429f4f
Author: Piotr Piórkowski <piotr.piorkowski@intel.com>

drm/xe/ggtt: Add KUnit tests for usable and shareable pools

This commit adds GGTT KUnit tests covering range initialization, allocation
direction, and pool conflicts for the usable and shareable GGTT pools in
native and PF modes.

> diff --git a/drivers/gpu/drm/xe/tests/xe_ggtt_kunit.c b/drivers/gpu/drm/xe/tests/xe_ggtt_kunit.c
> new file mode 100644
> index 0000000000000..03e4f212c62e5
> --- /dev/null
> +++ b/drivers/gpu/drm/xe/tests/xe_ggtt_kunit.c

[ ... ]

> +static struct xe_ggtt_node *ggtt_test_insert_node(struct kunit *test,
> +						  struct xe_ggtt *ggtt, u32 size)
> +{
> +	return ggtt_test_track_node(test, xe_ggtt_insert_node(ggtt, size, XE_PAGE_SIZE));
> +}
> +
> +static struct xe_ggtt_node *ggtt_test_insert_node_shareable(struct kunit *test,
> +							    struct xe_ggtt *ggtt, u32 size)
> +{
> +	return ggtt_test_track_node(test,
> +				    xe_ggtt_insert_node_shareable(ggtt, size, XE_PAGE_SIZE));
> +}

[Severity: Low]
Should ggtt_test_insert_node_shareable() be moved inside the
#if IS_ENABLED(CONFIG_PCI_IOV) block below?

In drivers/gpu/drm/xe/xe_ggtt.c and drivers/gpu/drm/xe/xe_ggtt.h,
xe_ggtt_insert_node_shareable() is only declared and defined under
#ifdef CONFIG_PCI_IOV, and all callers of ggtt_test_insert_node_shareable()
are inside the #if IS_ENABLED(CONFIG_PCI_IOV) block.

When building with CONFIG_DRM_XE_KUNIT_TEST=y and CONFIG_PCI_IOV=n, does this
fail to compile with an implicit function declaration for
xe_ggtt_insert_node_shareable() and an unused-function warning for
ggtt_test_insert_node_shareable()?

[ ... ]

> +#if IS_ENABLED(CONFIG_PCI_IOV)
> +static void init_shared_pf(struct kunit *test)
> +{

[ ... ]

> +}
> +#endif

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261020095532.473609-1-piotr.piorkowski@intel.com?part=4