Re: [PATCH v2] drm/xe/xe3: Fix OAM stream broken on Xe3+

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/xe/oa: tail address wrap helpers defined as macros despite v2 changelog
--

commit 5ceb7361283be3f44630db810b6ab0762b3744ab
Author: Shekhar Chauhan <shekhar.chauhan@intel.com>

drm/xe/xe3: Fix OAM stream broken on Xe3+

This commit prevents partial reports at the end of the oa buffer on Xe3+ oam
streams when overrun mode is enabled by rounding circ_size down to a multiple
of the report size.

> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index c9320feeafba8..f536fbccabb98 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -1751,6 +1751,15 @@ static const struct file_operations xe_oa_fops = {
>  	.mmap		= xe_oa_mmap,
>  };
>  
> +#define oag_has_tail_address_wrap(stream) \
> +	(GRAPHICS_VER((stream)->oa->xe) >= 20 && \
> +	 (stream)->oa_unit->type == DRM_XE_OA_UNIT_TYPE_OAG)
> +
> +#define oam_has_tail_address_wrap(stream) \
> +	(MEDIA_VER((stream)->oa->xe) >= 30 && \
> +	 ((stream)->oa_unit->type == DRM_XE_OA_UNIT_TYPE_OAM || \
> +	  (stream)->oa_unit->type == DRM_XE_OA_UNIT_TYPE_OAM_SAG))

[Severity: Low]
This isn't a runtime bug, but the v2 note in the commit message states:

  v2: Fix checkpatch issues by using a static func instead of #define.

However, in drivers/gpu/drm/xe/xe_oa.c, oag_has_tail_address_wrap() and
oam_has_tail_address_wrap() (used by xe_oa_stream_init() when initializing an
oa stream) are still defined as preprocessor macros that evaluate their
stream argument multiple times.

Were the v2 changes converting oag_has_tail_address_wrap() and
oam_has_tail_address_wrap() into static functions accidentally left out of
the commit?

> +
>  static int xe_oa_stream_init(struct xe_oa_stream *stream,
>  			     struct xe_oa_open_param *param)
>  {

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261021052333.1341575-2-shekhar.chauhan@intel.com?part=1