From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D88D606A31D for ; Fri, 23 Oct 2026 13:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=jzuAhy+/ Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EBB3112B4B; Fri, 23 Oct 2026 13:49:19 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A09C610E0A1; Fri, 23 Oct 2026 13:48:51 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 62D8642CEB; Fri, 23 Oct 2026 13:48:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E56951F01825; Fri, 23 Oct 2026 13:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792763331; bh=MQWn9R/Sdm3duYbyKyFhG1I7K4uNuiysT7qdpbhR5Ss=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=jzuAhy+/LdhVme5k+4ElEyE3+af0LcLSkSe0Ym0GA1n6rPqgtftNmI6Atnut0tFBT nkDzNIkbXo/yn0dwcmOlmITxJqrKILt33epzd7M9Aiat0IYApoXbot/5FzJlbzC73X wRCWSevgUmjn4miJcU3xaGq8jiYL0CA8cmL+I2ERd3KdC6enPr1wpZJcYvj4m0yBzW swIVSSCC22v/p5FFaK47YMIY16y4fEdWmon6yZKOhYtb/gaOC/DJLs3cwqsT+6q4rb 3zP+ukqGVbOYQ5ytdr6anm+Ecx47Bw3wiVB75DGaJiVMqhJMWcZLB7V7Pkl+wcIPKY M6AzllWsghiIA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 3/9] drm/bridge: pass down IRQ_HPD to the drivers To: "Dmitry Baryshkov" Cc: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <20261023-hpd-irq-events-v7-3-57a3aea3f09e@oss.qualcomm.com> References: <20261023-hpd-irq-events-v7-0-57a3aea3f09e@oss.qualcomm.com> <20261023-hpd-irq-events-v7-3-57a3aea3f09e@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 23 Oct 2026 13:48:50 +0000 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "Intel-xe" X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] drm/omap: missing event arg in hdmi5_bridge_hpd_notify() breaks bui= ld -- commit 8fdca4f38003a51e3d398ac403cb300b423a0ffc Author: Dmitry Baryshkov drm/bridge: pass down IRQ_HPD to the drivers This commit adds the enum drm_connector_dp_event parameter to the drm_bridge_funcs.hpd_notify callback so that DisplayPort IRQ_HPD events can be passed down to bridge drivers. [ ... ] > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4.c b/drivers/gpu/drm/omapdr= m/dss/hdmi4.c > index bd6c4d2dcdc86..72972a6fe989b 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi4.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4.c > @@ -429,7 +429,8 @@ static void hdmi4_bridge_disable(struct drm_bridge *b= ridge, > =20 > static void hdmi4_bridge_hpd_notify(struct drm_bridge *bridge, > struct drm_connector *connector, > - enum drm_connector_status status) > + enum drm_connector_status status, > + enum drm_connector_dp_event event) > { > struct omap_hdmi *hdmi =3D drm_bridge_to_hdmi(bridge); > =20 > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 1981d24a700d2..6382ef5f1ea28 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -509,7 +509,8 @@ struct drm_bridge_funcs { > */ > void (*hpd_notify)(struct drm_bridge *bridge, > struct drm_connector *connector, > - enum drm_connector_status status); > + enum drm_connector_status status, > + enum drm_connector_dp_event event); [Severity: Low] Does this break compilation when CONFIG_OMAP5_DSS_HDMI is enabled? While hdmi4_bridge_hpd_notify() in drivers/gpu/drm/omapdrm/dss/hdmi4.c is updated here, hdmi5_bridge_hpd_notify() in drivers/gpu/drm/omapdrm/dss/hdmi= 5.c still retains the old 3-argument signature: drivers/gpu/drm/omapdrm/dss/hdmi5.c: static void hdmi5_bridge_hpd_notify(struct drm_bridge *bridge, struct drm_connector *connector, enum drm_connector_status status) { struct omap_hdmi *hdmi =3D drm_bridge_to_hdmi(bridge); hdmi_audio_hpd_notify(hdmi, status); } ... static const struct drm_bridge_funcs hdmi5_bridge_funcs =3D { ... .hpd_notify =3D hdmi5_bridge_hpd_notify, .edid_read =3D hdmi5_bridge_edid_read, }; Assigning hdmi5_bridge_hpd_notify to hdmi5_bridge_funcs.hpd_notify causes an incompatible pointer type error during compilation when CONFIG_OMAP5_DSS_HD= MI is enabled, and also results in a function signature mismatch when drm_bridge_connector_hpd_notify() invokes bridge->funcs->hpd_notify(). It looks like the hunk updating hdmi5_bridge_hpd_notify() ended up in the subsequent commit c49a65530348 ("drm/bridge: pass extra events to the HPD callback"). Should that change be moved into this commit so that the tree remains bisectable? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261023-hpd-irq-ev= ents-v7-0-57a3aea3f09e@oss.qualcomm.com?part=3D3