Re: [PATCH v6 2/6] drm/xe/xe_late_bind_fw: Add string mappings of status codes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] drm/xe: missing BUFFER_TOO_SMALL mapping in xe_late_bind_parse_status()
--

commit d7b67485aab2684a93a389da87365dcc4bead83b
Author: Badal Nilawar <badal.nilawar@intel.com>

drm/xe/xe_late_bind_fw: Add string mappings of status codes

This commit adds string mappings in xe_late_bind_parse_status() for the new
late binding status codes introduced in the mei_lb driver.

> diff --git a/drivers/gpu/drm/xe/xe_late_bind_fw.c b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> index 1bddfaf0fb9f0..b7957e255ccde 100644
> --- a/drivers/gpu/drm/xe/xe_late_bind_fw.c
> +++ b/drivers/gpu/drm/xe/xe_late_bind_fw.c
> @@ -179,6 +179,32 @@ static const char *xe_late_bind_parse_status(uint32_t status)
>  		return "Invalid Payload";
>  	case INTEL_LB_STATUS_TIMEOUT:
>  		return "Timeout";
> +	case INTEL_LB_STATUS_INTERNAL_ERROR:
> +		return "Internal Error";

[Severity: Medium]
Should INTEL_LB_STATUS_BUFFER_TOO_SMALL also be handled here in
xe_late_bind_parse_status()?

Commit 773a43b8627f ("mei: lb: add late binding version 2") added status
codes 8 through 21 to enum intel_lb_status in
include/drm/intel/intel_lb_mei_interface.h:

	INTEL_LB_STATUS_TIMEOUT                              = 7,
	INTEL_LB_STATUS_BUFFER_TOO_SMALL                     = 8,
	INTEL_LB_STATUS_INTERNAL_ERROR                       = 9,

Without a case for INTEL_LB_STATUS_BUFFER_TOO_SMALL, if
late_bind->component.ops->push_payload() returns status 8 to
xe_late_bind_work(), xe_late_bind_parse_status() will fall through to the
default case and report "Unknown error".

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261030144547.2532309-8-badal.nilawar@intel.com?part=2