Re: [PATCH v4] drm/xe/guc: Demote uncorrectable local error log on CRI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] drm/xe/guc: comment and commit log mismatch with xe_gt_dbg()
--

commit c236f2b41d208ff40015648cc796be2b8ec71ef8
Author: Varun Gupta <varun.gupta@intel.com>

drm/xe/guc: Demote uncorrectable local error log on CRI

This commit demotes the GuC uncorrectable local error log on Crescent Island
(XE_CRESCENTISLAND) to debug level and ratelimits the error log when guc_id
is GUC_ID_UNKNOWN in xe_guc_uncorrectable_error_handler().

>     drm/xe/guc: Demote uncorrectable local error log on CRI
>     
>     The UNCORRECTABLE_LOCAL_ERROR notification sent by the GuC indicates a
>     local, queue-level context termination rather than a global device or
>     driver failure. On CRI, due to a hardware limitation, the platform cannot
>     distinguish GT translation faults from true RAS conditions, meaning
>     standard workloads routinely trigger this error.
>     
>     Printing this at ERROR level is too noisy and causes false-positive
>     dmesg-warn failures in CI. Demote the log level to INFO for CRI.
>     
>     v4:
>       - Change to _dbg instead of _info. (Matt)
>     v3:
>       - Limit the demotion to CRI and add comment explaining the HW limitation
>         (Rodrigo)
>     v2:
>       - Also ratelimit the GUC_ID_UNKNOWN to match the CAT error handler.
>         (Himal)
>     
>     Fixes: 4e57574fa3a3 ("drm/xe/guc: Handle GuC local uncorrectable error notifications")
>     Signed-off-by: Varun Gupta <varun.gupta@intel.com>

> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 9e7c2778029ca..8689c7ddc5fa0 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -3610,7 +3610,7 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
>  	guc_id = msg[0];
>  
>  	if (guc_id == GUC_ID_UNKNOWN) {
> -		xe_gt_err(gt, "GuC: Uncorrectable local error with unknown GuC id\n");
> +		xe_gt_err_ratelimited(gt, "GuC: Uncorrectable local error with unknown GuC id\n");
>  		return 0;
>  	}
>  
> @@ -3618,9 +3618,19 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
>  	if (unlikely(!q))
>  		return -EPROTO;
>  
> -	xe_gt_err(gt,
> -		  "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
> -		  guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);
> +	/*
> +	 * On CRI, the hardware cannot distinguish GT translation faults
> +	 * from true RAS conditions. Demote to info to avoid false-positive
> +	 * hardware error logs.
> +	 */
> +	if (gt_to_xe(gt)->info.platform == XE_CRESCENTISLAND)
> +		xe_gt_dbg(gt,
> +			  "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
> +			  guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);

[Severity: Low]
This isn't a bug, but in xe_guc_uncorrectable_error_handler(), v4 changed the
XE_CRESCENTISLAND branch to call xe_gt_dbg() while the comment right above it
and the commit message body still say it is demoted to info.

Also, changing xe_gt_err() to xe_gt_err_ratelimited() when guc_id ==
GUC_ID_UNKNOWN is only mentioned in the v2 changelog note and not in the main
commit description.

Should the comment and commit message be updated to reflect the debug log
level and the ratelimiting of GUC_ID_UNKNOWN?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261105145531.1847892-2-varun.gupta@intel.com?part=1