Re: [PATCH v1 1/4] drm/xe/cper: Add KUnit tests for CPER GUID mappings

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] drm/xe/cper: xe_cper.c includes KUnit suite with IS_ENABLED
  not IS_BUILTIN
- [Medium] drm/xe/cper: selecting UEFI_CPER without ACPI breaks x86
  !CONFIG_ACPI build
--

commit e55c9c6f9e07f010c97ca750586d2e6ff80ae6be
Author: Mallesh Koujalagi <mallesh.koujalagi@intel.com>

drm/xe/cper: Add KUnit tests for CPER GUID mappings

This commit adds KUnit tests in xe_cper_kunit.c to verify that CRI PCI IDs
and xe_device_guids[] entries stay in sync, and selects UEFI_CPER when
DRM_XE_KUNIT_TEST is enabled.

> diff --git a/drivers/gpu/drm/xe/Kconfig.debug b/drivers/gpu/drm/xe/Kconfig.debug
> index 79118d9efd93e..d7712460f2d52 100644
> --- a/drivers/gpu/drm/xe/Kconfig.debug
> +++ b/drivers/gpu/drm/xe/Kconfig.debug
> @@ -77,6 +77,7 @@ config DRM_XE_KUNIT_TEST
>          tristate "KUnit tests for the drm xe driver" if !KUNIT_ALL_TESTS
>  	depends on DRM_XE && KUNIT && DEBUG_FS
>  	default KUNIT_ALL_TESTS
> +	select UEFI_CPER if DRM_XE_KUNIT_TEST != n

[Severity: Medium]
Does selecting UEFI_CPER here without an ACPI dependency break x86 builds
when CONFIG_ACPI is disabled (such as with drivers/gpu/drm/xe/.kunitconfig)?

On x86, UEFI_CPER enables UEFI_CPER_X86, which compiles
drivers/firmware/efi/cper-x86.c.  cper_print_proc_ia() calls
arch_apei_report_x86_error(), which is declared in <asm/acpi.h> and only
included by <linux/acpi.h> when CONFIG_ACPI is enabled, causing an
implicit declaration build failure when CONFIG_ACPI=n.

[ ... ]

> diff --git a/drivers/gpu/drm/xe/xe_cper.c b/drivers/gpu/drm/xe/xe_cper.c
> index bb90030bcd2d4..f19e64dd51664 100644
> --- a/drivers/gpu/drm/xe/xe_cper.c
> +++ b/drivers/gpu/drm/xe/xe_cper.c
> @@ -320,3 +320,7 @@ int xe_cper_sysfs_init(struct xe_device *xe)
>  {
>  	return devm_device_add_group(xe->drm.dev, &cper_group);
>  }
> +
> +#if IS_ENABLED(CONFIG_DRM_XE_KUNIT_TEST)
> +#include "tests/xe_cper_kunit.c"
> +#endif

[Severity: Medium]
Should this guard use IS_BUILTIN(CONFIG_DRM_XE_KUNIT_TEST) instead of
IS_ENABLED(CONFIG_DRM_XE_KUNIT_TEST), matching other KUnit tests included
into core xe driver files (such as xe_log.c and xe_lmtt.c)?

xe_cper.o is linked into xe.ko rather than a separate test module, and
tests/xe_cper_kunit.c registers xe_cper_suite via kunit_test_suites().
When CONFIG_DRM_XE_KUNIT_TEST=m, IS_ENABLED() still compiles the suite
into xe.ko (or vmlinux if CONFIG_DRM_XE=y), so loading the driver runs
the KUnit suite immediately and taints the kernel with TAINT_TEST even
when no test module is loaded.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113115827.1913629-6-mallesh.koujalagi@intel.com?part=1