Re: [PATCH v3 2/2] drm/xe: Add debugfs stats for DMA-mapped pages per order

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/xe: build failure in xe_userptr.c when
  CONFIG_DRM_XE_GPUSVM=n
--

commit cdf22e3bf1d70b7d0f7e88b6b7825cfa6ceeb290
Author: Thomas Hellström <thomas.hellstrom@linux.intel.com>

drm/xe: Add debugfs stats for DMA-mapped pages per order

This commit adds per-order DMA-mapped system page counters for TTM buffer
objects and GPU SVM / userptr ranges, and exposes them in debugfs at
dma_mapped_pages.

> diff --git a/drivers/gpu/drm/xe/xe_userptr.c b/drivers/gpu/drm/xe/xe_userptr.c
> index 9c1dac0fce6f1..e657d7886a96b 100644
> --- a/drivers/gpu/drm/xe/xe_userptr.c
> +++ b/drivers/gpu/drm/xe/xe_userptr.c
> @@ -8,9 +8,38 @@
>  
>  #include <linux/mm.h>
>  
> +#include <drm/drm_pagemap.h>
> +
> +#include "xe_svm.h"
>  #include "xe_tlb_inval.h"
>  #include "xe_trace_bo.h"
>  
> +#if IS_ENABLED(CONFIG_DEBUG_FS)
> +static const struct drm_gpusvm_ops xe_userptr_gpusvm_ops = {
> +	.dma_map_account = xe_svm_dma_map_account,
> +};
> +#endif

[Severity: High]
Does xe_userptr.c fail to build when CONFIG_DRM_XE_GPUSVM=n,
CONFIG_DRM_GPUSVM=y and CONFIG_DEBUG_FS=y?

xe_userptr.o is built under CONFIG_DRM_GPUSVM, whereas
xe_svm_dma_map_account() is declared in the #if
IS_ENABLED(CONFIG_DRM_XE_GPUSVM) block of xe_svm.h and defined in xe_svm.c
(which is only built under CONFIG_DRM_XE_GPUSVM).  Moving
xe_svm_dma_map_account() to a header or into xe_userptr.c so both
configurations can use it would avoid the undeclared identifier error.

Also, xe_userptr.c already includes "xe_svm.h" at the top of the file, so
the new #include "xe_svm.h" is a duplicate.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261113190128.2118723-1-matthew.brost@intel.com?part=2