From: sashiko-bot@kernel.org
To: "Baoli Zhang" <baoli.zhang@linux.intel.com>,
intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915/display: Tear down encoder hardware state in a separate hook
Date: Mon, 16 Nov 2026 01:38:10 +0000 [thread overview]
Message-ID: <sashiko-outbox-216002@kernel.org> (raw)
In-Reply-To: <20261116011504.3910139-2-baoli.zhang@linux.intel.com>
Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] drm/i915/ddi: uninitialized dedicated_external check in
intel_ddi_init() [1]
--
commit 29c999b99f6cbc9e2b633d5c497aefc1594c72cf
Author: Baoli Zhang <baoli.zhang@linux.intel.com>
drm/i915/display: Tear down encoder hardware state in a separate hook
This commit introduces an intel_encoder ->remove() callback to separate
hardware and userspace-visible encoder teardown on driver remove from
memory deallocation in ->destroy().
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index a0aff087fafa8..01fbb5ab038fd 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
[ ... ]
> @@ -5353,6 +5358,7 @@ void intel_ddi_init(struct intel_display *display,
> encoder->initial_fastset_check = intel_ddi_initial_fastset_check;
> encoder->suspend = intel_ddi_encoder_suspend;
> encoder->shutdown = intel_ddi_encoder_shutdown;
> + encoder->remove = intel_ddi_encoder_remove;
> encoder->get_power_domains = intel_ddi_get_power_domains;
>
> encoder->type = INTEL_OUTPUT_DDI;
[Severity: High]
This problem wasn't introduced by this patch, but doesn't intel_ddi_init()
call intel_encoder_is_tc() before dig_port->dedicated_external is
initialized [1]?
intel_encoder_is_tc() returns false when dig_port->dedicated_external is
set, yet intel_ddi_init() only populates dedicated_external from VBT after
querying intel_encoder_is_tc() to select encoder->get_config and check
need_aux_ch():
drivers/gpu/drm/i915/display/intel_ddi.c:intel_ddi_init() {
...
if (HAS_LT_PHY(display)) {
...
if (intel_encoder_is_tc(encoder))
encoder->get_config = mtl_ddi_tc_phy_get_config;
else
encoder->get_config = mtl_ddi_non_tc_phy_get_config;
} else if (DISPLAY_VER(display) >= 14) {
...
if (intel_encoder_is_tc(encoder))
encoder->get_config = mtl_ddi_tc_phy_get_config;
else
encoder->get_config = mtl_ddi_non_tc_phy_get_config;
}
...
if (intel_bios_encoder_is_dedicated_external(devdata))
dig_port->dedicated_external = true;
...
}
On DISPLAY_VER() >= 14 or HAS_LT_PHY() platforms where the VBT marks a
Type-C PHY port as a dedicated external port, encoder->get_config is
assigned mtl_ddi_tc_phy_get_config() instead of
mtl_ddi_non_tc_phy_get_config(). Once dedicated_external is set to true,
subsequent intel_encoder_is_tc() calls return false, so atomic DPLL
computation uses the non-TC path (ICL_PORT_DPLL_DEFAULT) while hardware
state readout via mtl_ddi_tc_phy_get_config() populates
ICL_PORT_DPLL_MG_PHY, causing DPLL state verification mismatches and
failing fastset checks.
[1] https://sashiko.dev/#/bug/linux-4f65a789-b335-4420-aca7-1aaf9a2f9779
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116011504.3910139-1-baoli.zhang@linux.intel.com?part=1
next prev parent reply other threads:[~2026-11-16 1:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 1:15 [PATCH 0/3] drm/xe/display: Free the KMS objects on DRM device release, not on unbind Baoli Zhang
2026-11-16 1:15 ` [PATCH 1/3] drm/i915/display: Tear down encoder hardware state in a separate hook Baoli Zhang
2026-11-16 1:38 ` sashiko-bot [this message]
2026-11-16 1:15 ` [PATCH 2/3] drm/i915/display: Let the drivers free the KMS objects Baoli Zhang
2026-11-16 1:53 ` sashiko-bot
2026-11-16 8:39 ` Jani Nikula
2026-11-16 1:15 ` [PATCH 3/3] drm/xe/display: Free the KMS objects on DRM device release Baoli Zhang
2026-11-16 1:54 ` sashiko-bot
2026-11-16 1:35 ` ✓ CI.KUnit: success for drm/xe/display: Free the KMS objects on DRM device release, not on unbind Patchwork
2026-11-16 2:08 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-16 3:20 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-216002@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=baoli.zhang@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox