Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Eriksen Xie" <xiaolu.xie@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/dp_mst: Don't round up the PBN to whole TUs if not needed
Date: Mon, 16 Nov 2026 11:03:55 +0000	[thread overview]
Message-ID: <sashiko-outbox-216832@kernel.org> (raw)
In-Reply-To: <20261116105305.1374985-1-xiaolu.xie@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/i915/dp_mst: missing Fixes trailer for
  intel_dp_mtp_tu_compute_config()
--

commit 9569721c99c30b1c8df99a4e417744acb391988d
Author: Eriksen Xie <xiaolu.xie@intel.com>

> drm/i915/dp_mst: Don't round up the PBN to whole TUs if not needed
>
> intel_dp_mtp_tu_compute_config() rounds up the stream's PBN to a whole
> number of TUs (remote_tu * pbn_div) before passing it to
> drm_dp_atomic_find_time_slots(). The MST core uses this PBN both in the
> ALLOCATE_PAYLOAD messages and for checking the bandwidth limit of the
> path in drm_dp_mst_atomic_check_mstb_bw_limit(), against the
> Full_Payload_Bandwidth_Number reported by the branch device.
>
> Rounding up the PBN is needed only if the TU alignment required by the
> HW (4 / lane_count) increased the TU count, to make the TU count the MST
> core derives from the PBN match the TU count programmed to the HW.
> Otherwise the MST core derives the same TU count from the exact PBN as
> well.
>
> Rounding up needlessly can make a stream that would fit on the path
> exceed its limit. For instance 1920x1080@120 8 bpc needs 1022 PBN, which
> fits a port reporting 1024 PBN, but on a 4 lane HBR3 link (60 PBN per
> TU) it gets rounded up to 18 TUs = 1080 PBN. The stream then fails the
> check and the driver reduces it to 6 bpc (13 TUs).
>
> Round up the PBN to the aligned TU count only if the alignment changed
> the TU count, otherwise use the exact PBN.
>
> Tested with a PS8650 MST hub driving three 1920x1080@120 panels on Nova
> Lake: the streams now use 24 bpp (18 TUs, 1022 PBN out of the 1024 PBN
> limit) instead of 18 bpp.
>
> Signed-off-by: Eriksen Xie <xiaolu.xie@intel.com>

[Severity: Low]
This fixes the unconditional PBN round-up to whole TUs when TU alignment
does not change remote_tu.  Should this include a Fixes tag?

  Fixes: 1bcbe192e0dc ("drm/i915/dp_mst: Align TUs to avoid splitting symbols across MTPs")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116105305.1374985-1-xiaolu.xie@intel.com?part=1

      reply	other threads:[~2026-11-16 11:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 10:53 [PATCH] drm/i915/dp_mst: Don't round up the PBN to whole TUs if not needed Eriksen Xie
2026-11-16 11:03 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-216832@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=xiaolu.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox