Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Maarten Lankhorst" <dev@lankhorst.se>, intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v5 4/5] HACK: Always fallback
Date: Mon, 16 Nov 2026 13:25:45 +0000	[thread overview]
Message-ID: <sashiko-outbox-217070@kernel.org> (raw)
In-Reply-To: <20261116131349.333818-11-dev@lankhorst.se>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/xe/display: debug return false in
  xe_display_bo_fbdev_prefer_stolen()
--

commit a1da7ff8add8fa250f010995ce2e3a96fd7d5b05
Author: Maarten Lankhorst <dev@lankhorst.se>

HACK: Always fallback

This commit adds an unconditional return false to
xe_display_bo_fbdev_prefer_stolen().

> diff --git a/drivers/gpu/drm/xe/display/xe_display_bo.c b/drivers/gpu/drm/xe/display/xe_display_bo.c
> index 9385026a80b97..d78d893210c4f 100644
> --- a/drivers/gpu/drm/xe/display/xe_display_bo.c
> +++ b/drivers/gpu/drm/xe/display/xe_display_bo.c
> @@ -142,6 +142,8 @@ bool xe_display_bo_fbdev_prefer_stolen(struct xe_device *xe, unsigned int size)
>  	if (XE_DEVICE_WA(xe, 22019338487_display))
>  		return false;
>  
> +	return false;
> +
>  	/*
>  	 * If the FB is too big, just don't use it since fbdev is not very
>  	 * important and we should probably use that space with FBC or other

[Severity: Medium]
Was this temporary debug patch left in the series by mistake?

Returning false unconditionally makes the remaining stolen memory size
check unreachable and causes initial_plane_bo() to always discard the
BIOS framebuffer from stolen memory on integrated GPUs when
CONFIG_FRAMEBUFFER_CONSOLE and CONFIG_DRM_FBDEV_EMULATION are enabled,
while logging a misleading message:

drivers/gpu/drm/xe/display/xe_initial_plane.c:initial_plane_bo() {
    ...
		if (IS_ENABLED(CONFIG_FRAMEBUFFER_CONSOLE) &&
		    IS_ENABLED(CONFIG_DRM_FBDEV_EMULATION) &&
		    !xe_display_bo_fbdev_prefer_stolen(xe, plane_config->size)) {
			drm_info(&xe->drm, "Initial FB size exceeds half of stolen, discarding\n");
			return NULL;
		}
    ...
}

After commit "drm/i915: Introduce intel_bo_fbdev_bios_fb_takeover()",
this also forces xe_display_bo_fbdev_bios_fb_takeover() to always
allocate a new system memory BO and copy the BIOS framebuffer instead of
keeping eligible framebuffers in stolen memory.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116131349.333818-7-dev@lankhorst.se?part=4

  reply	other threads:[~2026-11-16 13:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 13:13 [PATCH v5 0/5] drm/xe/display: Transparant fallback from stolen to sysmem Maarten Lankhorst
2026-11-16 13:13 ` [PATCH v5 1/5] drm/xe/display: Avoid using stolen memory for framebuffer when media gt exists Maarten Lankhorst
2026-11-16 13:13 ` [PATCH v5 2/5] drm/xe/migrate: Support copying between sysmem and stolen Maarten Lankhorst
2026-11-16 13:29   ` sashiko-bot
2026-11-16 13:13 ` [PATCH v5 3/5] drm/xe: Raise gt frequency slightly earlier Maarten Lankhorst
2026-11-16 13:13 ` [PATCH v5 4/5] HACK: Always fallback Maarten Lankhorst
2026-11-16 13:25   ` sashiko-bot [this message]
2026-11-16 13:13 ` [PATCH v5 5/5] drm/i915: Introduce intel_bo_fbdev_bios_fb_takeover() Maarten Lankhorst
2026-11-16 13:26   ` Ville Syrjälä
2026-11-16 13:59   ` sashiko-bot
2026-11-16 15:53 ` ✗ CI.checkpatch: warning for drm/xe/display: Transparant fallback from stolen to sysmem. (rev6) Patchwork
2026-11-16 15:55 ` ✓ CI.KUnit: success " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-11-13 12:44 [PATCH v5 0/5] drm/xe/display: Transparant fallback from stolen to sysmem Maarten Lankhorst
2026-11-13 12:44 ` [PATCH v5 4/5] HACK: Always fallback Maarten Lankhorst
2026-11-13 12:50   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-217070@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dev@lankhorst.se \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox