From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF26860A2602 for ; Wed, 18 Nov 2026 13:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=J/n7RQw6 Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B7E9810E148; Wed, 18 Nov 2026 13:21:50 +0000 (UTC) Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2812410E148; Wed, 18 Nov 2026 13:21:45 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 0A9CF60D5D; Wed, 18 Nov 2026 13:21:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F3B41F000C4; Wed, 18 Nov 2026 13:21:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795008103; bh=YZZrDeTXdpYotDfA7TfV36hmlS+KRsIIEIpU0lT1b6Y=; h=From:Subject:Reply-To:To:In-Reply-To:References:Date; b=J/n7RQw6HplNAKxAg1sBQbmrV0IFYarHTdb1e3AExO98VnZHC3oaERvIx+ENiHQOb 5zmFR84kNgc7ebjkTMSQRVtcYTXq+fVkzJvT1kI66IodKyH1+kYhphNzIrHWyPWrVA w6sySx/HlS9HK3lYSGXaYEsr3YptlL/hTwTCNq79i1J3VjWi2rksrmlUiij8Lowo+0 AT31N5P5og4RXO548BJgf9Pa64NgJJiXMFFzDS+nx3yfx308BW6RWPz/rR5wKHnDiC TnM/B87Fgb2M8ENcAvht5TJMzxaYgmc1GuJyojSgQcT3+sQUoAkLWlIGB82lgnAYXh /fZqL8V75IavA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH] drm/i915/dip: Clear VSC_SELECT before setting it To: "Eriksen Xie" , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org In-Reply-To: <20261118131441.2023100-1-xiaolu.xie@intel.com> References: <20261118131441.2023100-1-xiaolu.xie@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 18 Nov 2026 13:21:43 +0000 X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "Intel-xe" X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/i915/dip: missing Fixes trailer for VSC_SELECT in hsw_write_infoframe() -- commit f244e26161b0f3b5713588fd3abc78616009d0e8 Author: Eriksen Xie > drm/i915/dip: Clear VSC_SELECT before setting it > > VSC_SELECT in VIDEO_DIP_CTL is a two bit field selecting whether the > header and the data of the VSC SDP are generated by the hardware or > taken from the DIP data registers. hsw_write_infoframe() ORs > VSC_DIP_HW_DATA_SW_HEA into the value read back from the register > without clearing the field first, so a different value left in it, > e.g. by the firmware, isn't replaced but combined with the new one > (VSC_DIP_HW_HEA_SW_DATA | VSC_DIP_HW_DATA_SW_HEA results in > VSC_DIP_SW_HEA_DATA). > > Clear the field before setting it. > > Signed-off-by: Eriksen Xie [Severity: Low] This fixes the unmasked VSC_SELECT bitfield update in hsw_write_infoframe(). Should this include: Fixes: bac2d7d8e64b ("drm/i915/display: Take care of VSC select field in = video dip ctl register") --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261118131441.2023= 100-1-xiaolu.xie@intel.com?part=3D1