Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Chaitanya Kumar Borah" <chaitanya.kumar.borah@intel.com>,
	intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/color: Program the 3D LUT on the plane's own pipe with joiner
Date: Thu, 19 Nov 2026 17:36:15 +0000	[thread overview]
Message-ID: <sashiko-outbox-223707@kernel.org> (raw)
In-Reply-To: <20261119165925.683691-1-chaitanya.kumar.borah@intel.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] drm/i915/color: intel_color_plane_commit_arm() disables 3D LUT
  on non-PLANE_1
- [Low] drm/i915/color: inaccurate commit message on joiner secondary
  plane uapi.crtc
--

commit fb7959aa23c8ae58895c1901c0ab349857f2f45e
Author: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

drm/i915/color: Program the 3D LUT on the plane's own pipe with joiner

This commit switches intel_color_plane_commit_arm() and
intel_color_load_3dlut() from plane_state->uapi.crtc to
plane_state->hw.crtc so 3D LUT registers are programmed on the plane's own
hardware pipe when joiner is active.

> With joiner, a secondary pipe plane's uapi.crtc points at the primary
> CRTC. intel_color_load_3dlut() and intel_color_plane_commit_arm() use
> it, so the 3D LUT is loaded and enabled twice on the primary pipe and
> never on the secondary, leaving the secondary pipe's part of the screen
> without it.

[Severity: Low]
Is this description of a joiner secondary plane's uapi.crtc accurate?

In intel_plane_copy_uapi_to_hw_state(), from_plane_state->uapi.crtc points
at the primary CRTC while the secondary plane's own plane_state->uapi.crtc
remains NULL, so to_intel_crtc(plane_state->uapi.crtc) evaluated to NULL
and skipped programming the secondary pipe rather than loading the 3D LUT
twice on the primary pipe.

> diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
> index f1df0f9ba7624..31958bee4717d 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -4275,7 +4275,7 @@ void intel_color_plane_commit_arm(struct intel_dsb *dsb,
>  				  const struct intel_plane_state *plane_state)
>  {
>  	struct intel_display *display = to_intel_display(plane_state);
> -	struct intel_crtc *crtc = to_intel_crtc(plane_state->uapi.crtc);
> +	struct intel_crtc *crtc = to_intel_crtc(plane_state->hw.crtc);
>  
>  	if (crtc && intel_color_crtc_has_3dlut(display, crtc->pipe))
>  		glk_lut_3d_commit(dsb, crtc, !!plane_state->hw.lut_3d);

[Severity: High]
Can this disable PLANE_1's active 3D LUT when a linked planar YUV Y-plane
or an overlay plane is committed on the same pipe?

glk_lut_3d_commit() writes the per-pipe LUT_3D_CTL(pipe) register bound to
PLANE_1, and only DRM_PLANE_TYPE_PRIMARY exposes the 3D LUT property, so
plane_state->hw.lut_3d is always NULL on other planes.
icl_plane_update_arm() calls intel_color_plane_commit_arm() for every
visible universal plane and linked Y-plane on the pipe.

For a linked Y-plane during planar YUV scanout on PLANE_1,
intel_plane_y_copy_hw_state() sets y_plane_state->hw.crtc to the CRTC
while leaving uapi.crtc and hw.lut_3d as NULL.  Switching to
plane_state->hw.crtc causes the linked Y-plane update (as well as any
visible overlay plane update) to call glk_lut_3d_commit(dsb, crtc, false),
clearing LUT_3D_CTL(pipe) to 0 on DSB commits or failing the LUT_3D_READY
check with drm_err() on MMIO commits.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119165925.683691-1-chaitanya.kumar.borah@intel.com?part=1

  reply	other threads:[~2026-11-19 17:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 16:59 [PATCH] drm/i915/color: Program the 3D LUT on the plane's own pipe with joiner Chaitanya Kumar Borah
2026-11-19 17:36 ` sashiko-bot [this message]
2026-11-19 23:39 ` ✓ CI.KUnit: success for " Patchwork
2026-11-20  0:15 ` ✓ Xe.CI.BAT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223707@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox