Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Umesh Nerlige Ramappa" <umesh.nerlige.ramappa@intel.com>,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v9 4/7] drm/xe/oa: Wait for in-flight OA batches before stream HW teardown
Date: Sat, 21 Nov 2026 02:11:32 +0000	[thread overview]
Message-ID: <sashiko-outbox-226541@kernel.org> (raw)
In-Reply-To: <20261121020145.147384-13-umesh.nerlige.ramappa@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/xe/oa: missing Fixes trailer for in-flight OA batch drain
  fix
--

commit 115bf9f1b769e2b40c1b9a0296a4a3bbf04bb581
Author: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>

> drm/xe/oa: Wait for in-flight OA batches before stream HW teardown
>
> Config batches submitted with output syncs and context LRI batches are
> not waited for. If one is still in flight when the stream is closed, it
> can program the OA registers after they were restored.
>
> Both go to the same exec queue, so also record the LRI batch fence in
> stream->last_fence, and wait for it before the HW teardown, bounded by
> the job timeout of the exec queue. Also wait for the LRI batch that
> disables the context save/restore of the OA counters during the HW
> teardown, which covers the stream init error path as well.
>
> A config batch with an input sync that doesn't signal sits in the
> scheduler, where no TDR times it out, and still runs once the sync
> signals, possibly reprogramming the OA config of a later stream. Don't
> kill the exec queue when the wait times out to prevent that: the TDR of
> a killed kernel exec queue resets the GT and can wedge the device.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Reviewed-by:  Shekhar Chauhan <shekhar.chauhan@intel.com>

[Severity: Low]
Commit dddcb19ad4d4 ("drm/xe/oa: Separate batch submission from waiting for
completion") dropped the synchronous wait from xe_oa_submit_bb(), leaving
context LRI batches submitted by xe_oa_load_with_lri() unwaited, and commit
343dd246fd9b ("drm/xe/oa: Signal output fences") made OA config batches
submitted with output syncs complete asynchronously without waiting for
stream->last_fence before tearing down OA hardware state.

Should this bug fix include Fixes tags for those commits:

  Fixes: dddcb19ad4d4 ("drm/xe/oa: Separate batch submission from waiting for completion")
  Fixes: 343dd246fd9b ("drm/xe/oa: Signal output fences")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121020145.147384-9-umesh.nerlige.ramappa@intel.com?part=4

  reply	other threads:[~2026-11-21  2:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  2:01 [PATCH v9 0/7] Cleanup OA stream on PCI unbind/remove Umesh Nerlige Ramappa
2026-11-21  2:01 ` [PATCH v9 1/7] drm/xe/oa: Ignore a HW tail pointer outside the OA buffer Umesh Nerlige Ramappa
2026-11-21  2:01 ` [PATCH v9 2/7] drm/xe/oa: Use the drm device address_space for the OA stream fd Umesh Nerlige Ramappa
2026-11-21  2:01 ` [PATCH v9 3/7] drm/xe: Reject vm_ops->access on BO mappings of an unplugged device Umesh Nerlige Ramappa
2026-11-21  2:01 ` [PATCH v9 4/7] drm/xe/oa: Wait for in-flight OA batches before stream HW teardown Umesh Nerlige Ramappa
2026-11-21  2:11   ` sashiko-bot [this message]
2026-11-21  2:01 ` [PATCH v9 5/7] drm/xe/oa: Fence OA ioctls and mmap against device unplug and wedging Umesh Nerlige Ramappa
2026-11-21  2:01 ` [PATCH v9 6/7] drm/xe/oa: Free the OA buffer and the stream after the stream destroy Umesh Nerlige Ramappa
2026-11-21  2:01 ` [PATCH v9 7/7] drm/xe/oa: Quiesce OA streams on driver unbind and PCI reset Umesh Nerlige Ramappa
2026-11-21  2:37   ` sashiko-bot
2026-11-21  2:09 ` ✗ CI.checkpatch: warning for Cleanup OA stream on PCI unbind/remove (rev9) Patchwork
2026-11-21  2:11 ` ✓ CI.KUnit: success " Patchwork
2026-11-21  2:48 ` ✗ Xe.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226541@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox