From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Stefan Roesch <shr@fb.com>, io-uring@vger.kernel.org, kernel-team@fb.com
Cc: viro@zeniv.linux.org.uk
Subject: Re: [PATCH v1] liburing: add test for stable statx api
Date: Thu, 10 Feb 2022 07:53:01 +0700 [thread overview]
Message-ID: <01a82b31-cd8c-b40d-ab30-c3a67e29ea41@gnuweeb.org> (raw)
In-Reply-To: <20220209190430.2378305-1-shr@fb.com>
On 2/10/22 2:04 AM, Stefan Roesch wrote:
> @@ -156,6 +211,16 @@ int main(int argc, char *argv[])
> goto err;
> }
>
> + ret = test_statx_stable(&ring, fname);
> + if (ret) {
> + if (ret == -EINVAL) {
> + fprintf(stdout, "statx not supported, skipping\n");
> + goto done;
> + }
> + fprintf(stderr, "test_statx_loop failed: %d\n", ret);
> + goto err;
> + }
> +
Why do we call it test_statx_loop? Isn't the function name test_statx_stable?
--
Ammar Faizi
next prev parent reply other threads:[~2022-02-10 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 19:04 [PATCH v1] liburing: add test for stable statx api Stefan Roesch
2022-02-10 0:43 ` Ammar Faizi
2022-02-10 0:53 ` Ammar Faizi [this message]
2022-02-10 2:06 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a82b31-cd8c-b40d-ab30-c3a67e29ea41@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=shr@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox