From: Jens Axboe <axboe@kernel.dk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: io-uring <io-uring@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] io_uring changes for 5.9-rc1
Date: Mon, 3 Aug 2020 17:31:53 -0600 [thread overview]
Message-ID: <025dcd45-46df-b3fa-6b4a-a8c6a73787b0@kernel.dk> (raw)
In-Reply-To: <56cb11b1-7943-086e-fb31-6564f4d4d089@kernel.dk>
On 8/3/20 5:18 PM, Jens Axboe wrote:
> On 8/3/20 4:30 PM, Jens Axboe wrote:
>>> Adding random kiocb helper functions to a core header file, when they
>>> are only used in one place, and when they only make sense in that one
>>> place?
>>>
>>> Not ok.
>>
>> I'll move that into io_uring instead.
>
> I see that you handled most of the complaints already, so thanks for
> that. I've run some basic testing with master and it works for me,
> running some more testing on production too.
>
> I took a look at the rewrite you queued up, and made a matching change
> on the io_uring side:
>
> https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.9&id=419ebeb6f2d0d56f6b2844c0f77034d1048e37e9
Updated to honor exclusive return value as well:
https://git.kernel.dk/cgit/linux-block/commit/?h=io_uring-5.9&id=f6fd3784c9f7d3309507fdb6dcc818f54467bf3e
--
Jens Axboe
next prev parent reply other threads:[~2020-08-03 23:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 21:41 [GIT PULL] io_uring changes for 5.9-rc1 Jens Axboe
2020-08-03 20:48 ` Linus Torvalds
2020-08-03 20:53 ` Linus Torvalds
2020-08-03 21:10 ` Konstantin Ryabitsev
2020-08-03 22:31 ` Jens Axboe
2020-08-03 22:30 ` Jens Axboe
2020-08-03 23:18 ` Jens Axboe
2020-08-03 23:31 ` Jens Axboe [this message]
2020-08-03 23:49 ` Linus Torvalds
2020-08-03 23:56 ` Jens Axboe
2020-08-04 0:11 ` Linus Torvalds
2020-08-03 23:34 ` Linus Torvalds
2020-08-03 23:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=025dcd45-46df-b3fa-6b4a-a8c6a73787b0@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox