From: Pavel Begunkov <asml.silence@gmail.com>
To: Dmitry Kadashev <dkadashev@gmail.com>, io-uring@vger.kernel.org
Subject: Re: Use of disowned struct filename after 3c5499fa56f5?
Date: Thu, 5 Nov 2020 14:26:49 +0000 [thread overview]
Message-ID: <042c50c4-0634-8001-ff90-85a9cb9632d3@gmail.com> (raw)
In-Reply-To: <1c1cd326-d99a-b15b-ab73-d5ee437db0fa@gmail.com>
On 05/11/2020 14:22, Pavel Begunkov wrote:
> On 05/11/2020 12:36, Dmitry Kadashev wrote:
>> Hi Jens,
>>
>> I am trying to implement mkdirat support in io_uring and was using
>> commit 3c5499fa56f5 ("fs: make do_renameat2() take struct filename") as
>> an example (kernel newbie here). But either I do not understand how it
>> works, or on retry struct filename is used that is not owned anymore
>> (and is probably freed).
BTW, I'll double check later today internals and the patch you've mentioned.
--
Pavel Begunkov
next prev parent reply other threads:[~2020-11-05 14:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 12:36 Use of disowned struct filename after 3c5499fa56f5? Dmitry Kadashev
2020-11-05 14:22 ` Pavel Begunkov
2020-11-05 14:26 ` Pavel Begunkov [this message]
2020-11-05 14:55 ` Pavel Begunkov
2020-11-05 19:37 ` Jens Axboe
2020-11-05 20:04 ` Pavel Begunkov
2020-11-05 20:18 ` Pavel Begunkov
2020-11-05 20:26 ` Jens Axboe
2020-11-05 20:35 ` Pavel Begunkov
2020-11-05 20:49 ` Jens Axboe
2020-11-05 20:57 ` Pavel Begunkov
2020-11-05 21:12 ` Jens Axboe
2020-11-06 10:08 ` Dmitry Kadashev
2020-11-06 12:49 ` Pavel Begunkov
2020-11-06 13:15 ` Dmitry Kadashev
2020-11-06 13:27 ` Pavel Begunkov
2020-11-06 13:35 ` Dmitry Kadashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=042c50c4-0634-8001-ff90-85a9cb9632d3@gmail.com \
--to=asml.silence@gmail.com \
--cc=dkadashev@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox