From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring: Fix getting file for timeout
Date: Thu, 14 Nov 2019 01:05:50 +0300 [thread overview]
Message-ID: <05f9e5fd-c60b-d483-381f-ad66cd3723e7@gmail.com> (raw)
In-Reply-To: <22C89598-0237-49ED-B020-9DD01D7EA31E@kernel.dk>
[-- Attachment #1.1: Type: text/plain, Size: 946 bytes --]
On 14/11/2019 00:54, Jens Axboe wrote:
> On Nov 13, 2019, at 2:48 PM, Pavel Begunkov <asml.silence@gmail.com> wrote:
>>
>> On 14/11/2019 00:37, Jens Axboe wrote:
>>>> On 11/13/19 2:33 PM, Jens Axboe wrote:
>>>> On 11/13/19 2:11 PM, Pavel Begunkov wrote:
>>>>> For timeout requests and bunch of others io_uring tries to grab a file
>>>>> with specified fd, which is usually stdin/fd=0.
>>>>> Update io_op_needs_file()
>>>>
>>>> Good catch, thanks, applied.
>>>
>>> Care to send one asap for 5.4 as well? It'd just be TIMEOUT for that
>>> one, but we need it fixed there, too.
>>>
>> Sure, I'll split this into 2 incremental patches then
>
> Just one patch is fine, it’ll be a conflict anyway. So no point in doing two patches for 5.5.
>
Ahh, didn't see the message.
I assumed you would drop the first one, and apply new 2 without a
conflict. Either way, just skip whatever you don't need
--
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-11-13 22:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 21:11 [PATCH] io_uring: Fix getting file for timeout Pavel Begunkov
2019-11-13 21:33 ` Jens Axboe
2019-11-13 21:37 ` Jens Axboe
2019-11-13 21:47 ` Pavel Begunkov
2019-11-13 21:54 ` Jens Axboe
2019-11-13 22:05 ` Pavel Begunkov [this message]
2019-11-13 22:27 ` Jens Axboe
2019-11-13 21:59 ` [PATCH for-linus] " Pavel Begunkov
2019-11-13 21:59 ` [PATCH for-5.5] io_uring: update io_op_needs_file Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05f9e5fd-c60b-d483-381f-ad66cd3723e7@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox