From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4EF21C7B79 for ; Thu, 3 Oct 2024 22:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727993542; cv=none; b=iJuugceFYGmOCFWOilSqADu1+VvqOTOAk0zsM0Q6B7LmkZzywF67d4jPXCWcPrRm3onsU2zLVSEe3xfpwWyFn3pqCNUsTpzgDuW+zhLZxhquvz9thQRaJ7qj0SSymrN3LJ4WdkavAXpwz38a2gMUlh/1blJbz0Gysup3U1Io9F4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727993542; c=relaxed/simple; bh=a4AdcKeTt6iaLudMXKCs6XY/L4nNm6MTDCdJdND06qc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=INrAauKhpwXmWPrQTzYyt6IDmBnOEvWO6QAXaG/XTlxv/giRDafhXRTsvelLQbgrHoCKeUVP1rTCPBI2AMkYfgh0KTBJrcuRUQYxQQ38ve4HpR/N8nn0ZVAdpubTZucHnuXjPILErBIDiD+yqAc/8OcsEsfDDDfSfk/HJ75CSjQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=zacgglKi; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="zacgglKi" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2e0af6e5da9so1160887a91.2 for ; Thu, 03 Oct 2024 15:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1727993540; x=1728598340; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UARFeoyZ3rHdhvutpLeLbLmTRofuJ6iiIPq0QcY6Mv0=; b=zacgglKiYJGuf0ENXqIZ5DDH9Nz12vqIFrXaW55eGEAzYfPcs4K3DvTM4kwg18kG6G S1T/aoJTFWqAYvZoXr/Jl9UwEDfOIWJCx+/G6kXjJQeIeBZ3IPIRKuUZaBUbkY88PV0/ WxBN38JrclDQ1jJ+g4bI+5b5A663x+0g5+asfMLMGPlz9FMhGYcsqmoVNA6bVFZP1qub 1atKNKKiz80nubs81sL8oFKPE11R+cbApwOine+ah06WV9x3XJMSdXFKGSCHutKylw4l 8J/vKzhXTXHcJKiF3JazdZFkCGakUL+lCeMGapf1xgSUTjc9M5FFX5WRQke0XKUKb2u1 y5+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727993540; x=1728598340; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UARFeoyZ3rHdhvutpLeLbLmTRofuJ6iiIPq0QcY6Mv0=; b=nhF4M2xaBvlaGef5dBiV5rMjnwpB5sgvcs/Q3YWPyPoaoqw0WOvK/IBznJXrQJ/LKW zHYWIGgeTaQns6qti2WhRH71xEyBzVGPhgFcN6qSZL4ayk8XFp2Xxbe3kscAMl/LSAJM UO76B6mwIIjnjBX96LRU8+fUUH/JqoYJJ92QaBrwTNvuGuWQr07wilS46HuQdDnA4Bub NrPV72gqEelDjjH5c0UprHV0F2Sdx6uNwGpWzgpZZHdiJRNByeUhGYZue82IknHZo2iK QlymMSuC6BuMlvaSnSsqi8t9ksGIjvqKwuvVykvHO15LhwJIc9iBKVZ08APsLt81jFHh /9GQ== X-Forwarded-Encrypted: i=1; AJvYcCUljkcpuh4D5IcScahv21CO0xbE712+8AGbyM67uOTEbjSlsXctJxRIBLkG3Cx7qDoIrxrpkybg9A==@vger.kernel.org X-Gm-Message-State: AOJu0Yxi+92yUkp3VZvv31P9RMjTFnzkSbm0zd0So203Czw4VadpOcXb 1alxKNB3i58CTCorPoHtMF8y5xPvWdGPvJtRgRXnjwMPRyvhHgnDHKffQwzwvVY= X-Google-Smtp-Source: AGHT+IHM56HG+I+buxx/PP0Ki+OL0sze0gS4TyHVsLh+P56KL+AQukx5RNv5DEf6lEpdxcaFxOgK0g== X-Received: by 2002:a17:90b:3796:b0:2e0:8bf4:f298 with SMTP id 98e67ed59e1d1-2e1e5dcf9b1mr686996a91.0.1727993540193; Thu, 03 Oct 2024 15:12:20 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e1e86abbc6sm4335a91.50.2024.10.03.15.12.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 15:12:19 -0700 (PDT) Message-ID: <09db3e2a-8f39-4ac3-ab7b-a2c8addabc77@kernel.dk> Date: Thu, 3 Oct 2024 16:12:16 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 0/3] FDP and per-io hints To: Bart Van Assche , Keith Busch , Christoph Hellwig Cc: "Martin K. Petersen" , Kanchan Joshi , hare@suse.de, sagi@grimberg.me, brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jaegeuk@kernel.org, bcrl@kvack.org, dhowells@redhat.com, asml.silence@gmail.com, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-block@vger.kernel.org, linux-aio@kvack.org, gost.dev@samsung.com, vishak.g@samsung.com, javier.gonz@samsung.com References: <20241001092047.GA23730@lst.de> <99c95f26-d6fb-4354-822d-eac94fdba765@kernel.dk> <20241002075140.GB20819@lst.de> <20241002151344.GA20364@lst.de> <20241002151949.GA20877@lst.de> <20241003125516.GC17031@lst.de> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/3/24 4:00 PM, Bart Van Assche wrote: > On 10/3/24 2:48 PM, Keith Busch wrote: >> The only "bonus" I have is not repeatedly explaining why people can't >> use h/w features the way they want. > > Hi Keith, > > Although that's a fair argument, what are the use cases for this patch > series? Filesystems in the kernel? Filesystems implemented in user > space? Perhaps something else? > > This patch series adds new a new user space interface for passing hints > to storage devices (in io_uring). As we all know such interfaces are > hard to remove once these have been added. It's a _hint_, I'm not sure how many times that has to be stated. The kernel is free to ignore it, and in the future, it may very well do that. We already had fcntl interfaces for streams, in the same vein, and we yanked those in the sense that they ended up doing _nothing_. Did things break because of that? Of course not. This is no different. > We don't need new user space interfaces to support FDP for filesystems > in the kernel. > > For filesystems implemented in user space, would using NVMe pass-through > be a viable approach? With this approach, no new user space interfaces > have to be added. > > I'm wondering how to unblock FDP users without adding a new > controversial mechanism in the kernel. pass-through already works, obviously - this is more about adding a viable real interface for it. If it's a feature that is in devices AND customers want to use, then pointing them at pass-through is a cop-out. -- Jens Axboe