From: Jens Axboe <axboe@kernel.dk>
To: Ankit Kumar <ankit.kumar@samsung.com>
Cc: io-uring@vger.kernel.org, joshi.k@samsung.com
Subject: Re: [PATCH liburing v3 0/5] Add basic test for nvme uring passthrough commands
Date: Thu, 28 Jul 2022 06:36:51 -0600 [thread overview]
Message-ID: <0a9c81d0-d6f6-effd-5d3f-132a92d54205@kernel.dk> (raw)
In-Reply-To: <20220728093327.32580-1-ankit.kumar@samsung.com>
On 7/28/22 3:33 AM, Ankit Kumar wrote:
> This patchset adds a way to test NVMe uring passthrough commands with
> nvme-ns character device. The uring passthrough was introduced with 5.19
> io_uring.
>
> To send nvme uring passthrough commands we require helpers to fetch NVMe
> char device (/dev/ngXnY) specific fields such as namespace id, lba size etc.
>
> How to run:
> ./test/io_uring_passthrough.t /dev/ng0n1
>
> It requires argument to be NVMe device, if not the test will be skipped.
>
> The test covers write/read with verify for sqthread poll, vectored / nonvectored
> and fixed IO buffers, which can be extended in future. As of now iopoll is not
> supported for passthrough commands, there is a test for such case.
>
> Changes from v2 to v3
> - Skip test if argument is not nvme device and remove prints, as
> suggested by Jens.
> - change nvme helper function name, as pointed by Jens.
> - Remove wrong comment about command size, as per Kanchan's review
I didn't get patch 2/5, and lore didn't either. Can you resend the series?
--
Jens Axboe
next prev parent reply other threads:[~2022-07-28 12:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220728093902epcas5p40813f72b828e68e192f98819d29b2863@epcas5p4.samsung.com>
2022-07-28 9:33 ` [PATCH liburing v3 0/5] Add basic test for nvme uring passthrough commands Ankit Kumar
2022-07-28 9:33 ` [PATCH liburing v3 1/5] configure: check for nvme uring command support Ankit Kumar
2022-07-28 9:33 ` [PATCH liburing v3 2/5] io_uring.h: sync sqe entry with 5.20 io_uring Ankit Kumar
2022-07-28 9:33 ` [PATCH liburing v3 3/5] nvme: add nvme opcodes, structures and helper functions Ankit Kumar
2022-07-28 9:33 ` [PATCH liburing v3 4/5] test: add io_uring passthrough test Ankit Kumar
2022-07-28 9:33 ` [PATCH liburing v3 5/5] test/io_uring_passthrough: add test case for poll IO Ankit Kumar
2022-07-28 12:36 ` Jens Axboe [this message]
2022-07-28 13:01 ` [PATCH liburing v3 0/5] Add basic test for nvme uring passthrough commands Ankit Kumar
2022-07-28 13:10 ` Jens Axboe
2022-07-28 13:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a9c81d0-d6f6-effd-5d3f-132a92d54205@kernel.dk \
--to=axboe@kernel.dk \
--cc=ankit.kumar@samsung.com \
--cc=io-uring@vger.kernel.org \
--cc=joshi.k@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox