From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Subject: Re: [PATCH v2] io_uring: fix skipping disabling sqo on exec
Date: Sat, 16 Jan 2021 21:04:11 -0700 [thread overview]
Message-ID: <0ca2bd29-4d61-8246-b3dd-661f77be165b@kernel.dk> (raw)
In-Reply-To: <aafb4f9c5380abad2142d33f4969ae5ac32f2c31.1610850562.git.asml.silence@gmail.com>
On 1/16/21 7:29 PM, Pavel Begunkov wrote:
> If there are no requests at the time __io_uring_task_cancel() is called,
> tctx_inflight() returns zero and and it terminates not getting a chance
> to go through __io_uring_files_cancel() and do
> io_disable_sqo_submit(). And we absolutely want them disabled by the
> time cancellation ends.
Thanks, that looks much better! Applied.
--
Jens Axboe
prev parent reply other threads:[~2021-01-17 4:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 2:29 [PATCH v2] io_uring: fix skipping disabling sqo on exec Pavel Begunkov
2021-01-17 4:04 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ca2bd29-4d61-8246-b3dd-661f77be165b@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox