Re: [PATCH 5.13 v2] io_uring: maintain drain requests' logic

Jens Axboe
2021-04-07T15:50:08Z

On 4/7/21 5:23 AM, Hao Xu wrote:
> more tests comming, send this out first for comments.
>
> Hao Xu (3):
> io_uring: add IOSQE_MULTI_CQES/REQ_F_MULTI_CQES for multishot requests
> io_uring: maintain drain logic for multishot requests
> io_uring: use REQ_F_MULTI_CQES for multipoll IORING_OP_ADD
>
> fs/io_uring.c | 34 +++++++++++++++++++++++++++++-----
> include/uapi/linux/io_uring.h | 8 +++-----
> 2 files changed, 32 insertions(+), 10 deletions(-)

Let's do the simple cq_extra first. I don't see a huge need to add an
IOSQE flag for this, probably best to just keep this on a per opcode
basis for now, which also then limits the code path to just touching
poll for now, as nothing else supports multishot CQEs at this point.

--
Jens Axboe