From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
Hao Xu <haoxu@linux.alibaba.com>
Cc: io-uring@vger.kernel.org, Joseph Qi <joseph.qi@linux.alibaba.com>
Subject: Re: [PATCH io_uring-5.14 v2] io_uring: remove double poll wait entry for pure poll
Date: Fri, 23 Jul 2021 10:22:10 -0600 [thread overview]
Message-ID: <12552166-8d0c-2cbb-faec-ec320f171f13@kernel.dk> (raw)
In-Reply-To: <c628d5bc-ee34-bf43-c7bc-5b52cf983cb1@gmail.com>
On 7/23/21 8:31 AM, Pavel Begunkov wrote:
> On 7/23/21 10:22 AM, Hao Xu wrote:
>> For pure poll requests, we should remove the double poll wait entry.
>> And io_poll_remove_double() is good enough for it compared with
>> io_poll_remove_waitqs().
>
> 5.14 in the subject hints me that it's a fix. Is it?
> Can you add what it fixes or expand on why it's better?
Ditto that, the commit message explains what is being done, it should
explain _why_ it's being done. For the 'what' part you can read the
code. So while the patch doesn't look wrong, I also can't quite tell why
the change is necessary.
--
Jens Axboe
next prev parent reply other threads:[~2021-07-23 16:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 9:22 [PATCH io_uring-5.14 v2] io_uring: remove double poll wait entry for pure poll Hao Xu
2021-07-23 14:31 ` Pavel Begunkov
2021-07-23 16:22 ` Jens Axboe [this message]
2021-07-24 4:48 ` Hao Xu
2021-07-26 12:40 ` Pavel Begunkov
2021-07-26 14:39 ` Hao Xu
2021-07-27 22:46 ` Jens Axboe
2021-07-28 6:06 ` Hao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12552166-8d0c-2cbb-faec-ec320f171f13@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=haoxu@linux.alibaba.com \
--cc=io-uring@vger.kernel.org \
--cc=joseph.qi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox