From: Pavel Begunkov <asml.silence@gmail.com>
To: Usama Arif <usama.arif@bytedance.com>,
io-uring@vger.kernel.org, axboe@kernel.dk,
linux-kernel@vger.kernel.org
Cc: fam.zheng@bytedance.com
Subject: Re: [PATCH v5 4/4] io_uring: remove ring quiesce for io_uring_register
Date: Fri, 4 Feb 2022 00:28:51 +0000 [thread overview]
Message-ID: <130345c9-e8fb-2f13-59fd-368334b49235@gmail.com> (raw)
In-Reply-To: <f592de55-5a5c-e715-95c4-d219266bcd9e@gmail.com>
On 2/3/22 23:47, Pavel Begunkov wrote:
> On 2/3/22 23:34, Usama Arif wrote:
>> Ring quiesce is currently only used for 2 opcodes
>> IORING_REGISTER_ENABLE_RINGS and IORING_REGISTER_RESTRICTIONS.
>> IORING_SETUP_R_DISABLED prevents submitting requests and
>> so there will be no requests until IORING_REGISTER_ENABLE_RINGS
>> is called. And IORING_REGISTER_RESTRICTIONS works only before
>> IORING_REGISTER_ENABLE_RINGS is called. Hence ring quiesce is
>> not needed for these opcodes and therefore io_uring_register.
>
> I think I'd prefer to retain quiesce code than reverting this
> patch later.
btw, if it gets to reverting it'll be easier if this patch
is split in 2. The first puts these 2 opcodes into
io_register_op_must_quiesce(), we definitely want to keep
that. And the other doing the rest of cleanup
--
Pavel Begunkov
next prev parent reply other threads:[~2022-02-04 0:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 23:34 [PATCH v5 0/4] io_uring: remove ring quiesce in io_uring_register Usama Arif
2022-02-03 23:34 ` [PATCH v5 1/4] io_uring: remove trace for eventfd Usama Arif
2022-02-03 23:34 ` [PATCH v5 2/4] io_uring: avoid ring quiesce while registering/unregistering eventfd Usama Arif
2022-02-03 23:46 ` Pavel Begunkov
2022-02-03 23:54 ` Pavel Begunkov
2022-02-04 0:12 ` Jens Axboe
2022-02-03 23:34 ` [PATCH v5 3/4] io_uring: avoid ring quiesce for IORING_REGISTER_EVENTFD_ASYNC Usama Arif
2022-02-03 23:34 ` [PATCH v5 4/4] io_uring: remove ring quiesce for io_uring_register Usama Arif
2022-02-03 23:47 ` Pavel Begunkov
2022-02-04 0:28 ` Pavel Begunkov [this message]
2022-02-04 0:02 ` [PATCH v5 0/4] io_uring: remove ring quiesce in io_uring_register Pavel Begunkov
2022-02-04 0:15 ` Jens Axboe
2022-02-04 0:24 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130345c9-e8fb-2f13-59fd-368334b49235@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=fam.zheng@bytedance.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=usama.arif@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox