Re: [PATCH v5 4/4] io_uring: remove ring quiesce for io_uring_register

Pavel Begunkov
2022-02-04T00:34:02Z

On 2/3/22 23:47, Pavel Begunkov wrote:
> On 2/3/22 23:34, Usama Arif wrote:
>> Ring quiesce is currently only used for 2 opcodes
>> IORING_REGISTER_ENABLE_RINGS and IORING_REGISTER_RESTRICTIONS.
>> IORING_SETUP_R_DISABLED prevents submitting requests and
>> so there will be no requests until IORING_REGISTER_ENABLE_RINGS
>> is called. And IORING_REGISTER_RESTRICTIONS works only before
>> IORING_REGISTER_ENABLE_RINGS is called. Hence ring quiesce is
>> not needed for these opcodes and therefore io_uring_register.
>
> I think I'd prefer to retain quiesce code than reverting this
> patch later.

btw, if it gets to reverting it'll be easier if this patch
is split in 2. The first puts these 2 opcodes into
io_register_op_must_quiesce(), we definitely want to keep
that. And the other doing the rest of cleanup

--
Pavel Begunkov